Refactoring/gcp/cloudresourcemanager #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remi05
added
component-provider-gcp
Codecov Report
@@ Coverage Diff @@
## develop #231 +/- ##
===========================================
+ Coverage 35.17% 35.29% +0.12%
===========================================
Files 174 176 +2
Lines 5715 5734 +19
===========================================
+ Hits 2010 2024 +14
- Misses 3705 3710 +5
Continue to review full report at Codecov.
|
|
👏 👏 👏 |
Aboisier
reviewed
Mar 7, 2019
misg
reviewed
Mar 7, 2019
53 tasks
|
Added left menu for projects and fixed UI. Before :
After :
|
…p/cloudresourcemanager
Remi05
changed the base branch from
develop
to
refactoring/gcp/stackdriverlogging
Aboisier
reviewed
Apr 2, 2019
ScoutSuite/providers/gcp/resources/cloudresourcemanager/service.py
Outdated
Show resolved
Hide resolved
Aboisier
reviewed
Apr 2, 2019
ScoutSuite/providers/gcp/resources/cloudresourcemanager/service.py
Outdated
Show resolved
Hide resolved
Aboisier
approved these changes
Apr 2, 2019
…e.py Co-Authored-By: Remi05 <remi_pelletier_6@hotmail.com>
…p/cloudresourcemanager
Remi05
changed the base branch from
refactoring/gcp/stackdriverlogging
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated GCP's Cloud Resource Manager service to the new architecture.
Note that
gcp/resources/projects.pyandgcp/facade/base.pyare the same as in the Stackdriver logging PR and the IAM PR; they are simply shared by all services and will appear in all GCP refactoring PRs until one of the services is merged.