fix: Add hardcoded ETH price feed ID for Pyth as stop-gap solution #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `AgentKit.from` argument keys from cdpApiKeyPrivate -> cdpApiKeySecret
* feat: rewrote x402ActionProvider to work much better * feat: added README * chore: added changeset
…inbase#778) * feat: added x402ActionProvider to python and added to one example * feat: unit tests * feat: added changelog and readme changes * feat: on retry, using original selected payment requirements for selection * chore: sync locks * fix: unit tests * chore: disabled 3 tests struggling to mock requests
* fix: cdp_evm_smart_wallet_provider sign_typed_data implementation * rename: CdpEvmServerWalletProvider to CdpEvmWalletProvider in python * fix: chore: removed unused code * chore: removed logs * feat: validate x402 action provider works with cdp wallet providers in ts * feat: rename CdpEvmSmartWalletProvider to CdpSmartWalletProvider * revert: changelog update * chore: changelogs * feat: validated create-onchain-agent in python * feat: validated create-onchain-agent in typescript * fix: format/lint/locks * fix: updated workflows for example changes in python * fix: typescript unit tests * fix: python unit tests * feat: changesets * fix: added missing env vars to cli
* unwrap weth action * updated docs * description fix, updated README * changeset updated
* Added media upload support for Twitter and embeds support for Farcaster * improve action description
* strands agents framework extension * strands agents extension example chatbot * Create .env.local * Delete python/examples/strands-agents-cdp-server-chatbot/wallet_data_base_sepolia.txt * Update README.md
* add zora action provider * remove walletClient dep * rebase * update to zora coins sdk v4
* add truemarkets action provider * added tests * use multicall for more efficient rpc queries * use multicall for get_market_details * fix tyd markets * improve prompt
* feat: prepare strands agents for pypi packaging * feat: added coinbase-agentkit dependency to framework extension * chore: Removed AlloraActionProvider due to depps conflict * temp: strands references local python to bypass lock gha
* add paymaster to cdp smart wallet * add changeset
* feat(TS): Integrate Zerion API for agentkit * chore: resolve comments
… (ts,python) (coinbase#824) * add getPublicClient and RPC_URL config * update actions to use wallet public client * add custom RPC url (python) * add changelog entry
* update readmes and contributing guide * add missing wallet providers to docs
* feat: add pydantic ai framework extension * feat: add docs * style: apply format * feat: add if args_schema * feat: add MakeFile * feat: add uv lock * chore: remove type ignore * feat: add nest asyncio deps * docs: add docstring * feat: add pydantic ai cdp server example * docs: add readme for example * docs: add pydantic ai to python/readme * feat: update agentkit version * style: apply format * chore: remove git ignore * feat: add .env.local * feat: add makefile for example * feat: remove unused make commands * fix: fix import wallet providers * chore: update uv.lock * refactor: change example dir name * feat: remove duplicated dependencies, add pydantic ai link to readme * docs: update docstring * tests: add test case * feat: update uvlock * feat: update uvlock * feat: update uv.lock with agentkit 0.7.1 * feat: update uv.lock * feat: update uv.lock * feat: update uv.lock * update uv.lock --------- Co-authored-by: Philippe d'Argent <p.dargent@cern.ch>
* fix swap api * get correct account for smart wallets * add paymaster * add owner as signer to swap * improve smart wallet check * rebased * refine prompt * getTokenDetails with multicall * create cdp server account as owner by default * throw error for non cdp owner account * add retry and swap status check * update next smart wallet example * refactor swap actions
- Added hardcoded price feed ID for ETH (0xff61491a931112ddf1bd8147cd1b641375f79f5825126d665480874634fd0ace) - This is a temporary stop-gap solution until proper new API link is provided after talking to the Pyth team - Updated both Python and TypeScript implementations
github-actions
bot
added
documentation
- Remove trailing whitespace from blank lines in both Python and TypeScript files - Fixes ruff and prettier formatting issues
- Changed test that expected ETH to throw error to use SOL instead - Added new test to verify ETH returns hardcoded price feed ID - Tests now properly reflect the stop-gap solution behavior
- Added trailing comma and line breaks for long string in test - Fixes eslint/prettier formatting requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a hardcoded price feed ID for ETH in the Pyth action provider as a temporary stop-gap solution.
Changes
0xff61491a931112ddf1bd8147cd1b641375f79f5825126d665480874634fd0aceContext
This change addresses an issue with fetching ETH price feed ID from Pyth's API. The hardcoded value ensures consistent behavior for ETH price queries while we wait for the proper API update from the Pyth team.
Testing
Note
This is explicitly marked as a stop-gap solution in the code comments and should be revisited once the Pyth team provides the proper API endpoint.