-
Notifications
You must be signed in to change notification settings - Fork 592
feat: Pydantic AI framework extension #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
|
Hi @Ilevk, thanks for your contribution! Looks great, a few initial comments below before I do some testing. |
|
Note that we require signed commits. See here for instructions on setting up commit signing. Once setup, rebase against main to re-sign all commits. |
python/examples/pydantic-ai-cdp-server-chatbot/initialize_agent.py
Outdated
Show resolved
Hide resolved
81d38cd to
c8edafc
Compare
|
I rebased all commits |
|
Thanks for the updates @Ilevk ! Will test it later today. It would be great if you could also add a few basic unit tests as in https://github.com/coinbase/agentkit/tree/main/python/framework-extensions/openai-agents-sdk/tests |
| "ignore::pydantic.PydanticDeprecatedSince20", | ||
| ] | ||
|
|
||
| [tool.uv] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can [tool.uv] be removed? mypy, ruff dependencies already in [dependency-groups] with conflicting versions. seems
"ruff>=0.7.1,<0.8",
"mypy>=1.13.0,<2",
also used in other frameworks (https://github.com/coinbase/agentkit/blob/main/python/framework-extensions/strands-agents/pyproject.toml), better stick to those I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for comments!
|
Also a link to pydantic ai docs would be good in framework and chatbot readme |
|
Thanks for the quick turnaround @Ilevk, great job! I tested it and think its good to go @CarsonRoscoe |
bf8fbd4 to
e7f0d8f
Compare
|
@phdargen I've rebased this PR with main to apply Agentkit 0.7.1 |
Thanks! @CarsonRoscoe could you please approve the workflow to see if the tests pass? |
|
@CarsonRoscoe Hey how's it going? please let me know what should I do. |
Hi @Ilevk, I checked out your code and ran uv sync in Is this what you tried before? |
|
Hi @CarsonRoscoe @murrlincoln, could you please approve this workflow to check if this passes now? |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, apologies for not following up on this.
Re-ran the workflow, still the issue here. @phdargen though has this working in #826, which is just branched off your commit.
I'm leaning towards merging phdargen's PR. It retains your authorship, it just adds one commit to fix the lock file. You would still be considered the author of your commits.
If this is fine with you, let me know and we'll get it in asap. Alternatively, try to run phdargen's steps/steal his commit from his PR and we'll get it in
Thank you two for your patience
|
@CarsonRoscoe Could you take a look at my comments? I guess the commit I cherry-picked isn’t working at the moment. If it fails again this time, it would be fine to merge the PR from @phdargen (#826). I really appreciate it! 😊 |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Looking good!
|
Finally It's done. it couldn't have done without your support. Thank you! |

Description
coinbase-agentkit-pydantic-aiextensions inpython/framework-extensions/pydantic-aiget_pydantic_ai_tools()funtions to provide AgentKit actions as PydanticAI Toolpython/examples/pydantic-ai-cdp-server-chatbot.pyWith this PR, developers building agents using the Pydantic AI framework will now be able to implement Based Agents with AgentKit.
Tests
Checklist
A couple of things to include in your PR for completeness: