Skip to content

update readme/contributing guides #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarsonRoscoe merged 2 commits into from
Aug 15, 2025
Merged

update readme/contributing guides #822

CarsonRoscoe merged 2 commits into from
Aug 15, 2025

Conversation

@phdargen
Copy link
Contributor

@phdargen phdargen commented Aug 12, 2025

Description

A few docs fixes:

  • Updates examples/framework extensions in READMEs
  • Adds commit signing info to contributing guide
  • Improves changeset instructions
  • Node.js v18.x -> Node.js v22.x

@phdargen phdargen requested a review from murrlincoln as a code owner August 12, 2025 16:33
@cb-heimdall
Copy link

cb-heimdall commented Aug 12, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 12, 2025
CarsonRoscoe
CarsonRoscoe approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, ty

@CarsonRoscoe CarsonRoscoe merged commit d3c7d96 into coinbase:main Aug 15, 2025
26 checks passed
@phdargen phdargen mentioned this pull request Sep 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarsonRoscoe CarsonRoscoe CarsonRoscoe approved these changes

@murrlincoln murrlincoln Awaiting requested review from murrlincoln murrlincoln is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phdargen @cb-heimdall @CarsonRoscoe