-
Notifications
You must be signed in to change notification settings - Fork 592
feat(TS): Integrate Zerion API for agentkit #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
|
This is a continuation of #696 |
|
Hi @pcminh0505, thanks for the update! Looks good and I tested it without issues. Just a few more cosmetic changes, see below |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@coinbase/agentkit": minor | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor -> patch
Add -> Added
|
|
||
| ## Overview | ||
|
|
||
| The ZerionActionProvider is designed to work with EvmWalletProvider for blockchain interactions. It provides a set of actions that enable [describe the main purpose/functionality]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace placeholder with description.
Also add to the README that a Zerion api key is required and where to get one
| walletAddress: z | ||
| .string() | ||
| .describe( | ||
| "The wallet address to fetch portfolio for (defaults to connected wallet if not provided)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to remove "(defaults to connected wallet if not provided)"
| * | ||
| * @description | ||
| * This provider is designed to provide blockchain-agnostic operations. | ||
| * It supports all blockchain networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It supports all EVM networks.
|
Hi @phdargen , resolved minor comments you added. Please check again. |
|
Thanks for the quick changes @pcminh0505! This is tested and good to go @CarsonRoscoe |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution and review :)
Description
get_portfolio_overview: Get aggregated USD balance of a wallet addressget_fungible_positions: Get aggregated token positions (wallet and DeFi) of a wallet addressRequirement: Zerion API key
Example
get_portfolio_overviewget_fungible_positionsTests
Checklist
A couple of things to include in your PR for completeness: