-
Notifications
You must be signed in to change notification settings - Fork 592
feat(TS): Integrate Zerion API for agentkit #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* 0.1.0 initial scaffolding (#175) * chore: fix lint (#177) * chore: migrate basename action (#176) * chore: CDP, Farcaster, ERC721 action providers (#181) * CDP, Farcaster, ERC721 ActionProvider * README erc721 * chore: migrate erc20 action (#182) * 0.1.0(ts): morpho actions (#184) * chore: migrate erc20 getBalance (#186) * chore: fix npm scripts, linting and bump lint packages (#179) * chore: migrate erc721 getBalance (#188) * chore: migrate wrap eth action (#189) * chore: langchain helper to convert actions to tools (#190) * 0.1.0(ts): wow actions (#191) * chore: migrate get wallet details (#192) * 0.1.0(ts): twitter actions (#193) * chore: eslint import order (#194) * chore: map chainId to networkId (#196) * chore: fix typo (#197) * chore: migrate deploy token (#198) * 0.1.0(ts): deploy contract (#201) * first pass adding deploy contract cdp action * linting * the lost file * tests * 0.1.0(ts): adding eth balance to wallet details (#199) * feat: Client side metrics (#195) * 0.1.0(ts): deploy nft (#200) * chore: rename typescript files and folders (#203) * chore: split out cdp wallet and cdp api actions (#204) * chore: migrate trade action (#208) * twitter chatbot example (#205) * 0.1.0(ts): farcaster example (#206) * chore: cdpApiActionProvider usage (#211) * chore: prefix action name (#210) * chore: set default action provider to wallet action provider (#212) * 0.1.0(ts): wallet native token transfer (#213) Co-authored-by: John Peterson <98187317+John-peterson-coinbase@users.noreply.github.com> * fix: use prefix notation that plays nicely with langchain (#217) * feat: support custom action provider (#214) * 0.1.0(ts): cdp wallet provider (#218) Co-authored-by: John Peterson <98187317+John-peterson-coinbase@users.noreply.github.com> * feat: CdpWalletProvider sendTransaction * fix cdp provider config fields * docs + dir structure refactor * add language level readmes * release ready! * fix agentkit-langchain unit tests * fix python unit test GHA poetry relative paths * update poetry lock files --------- Co-authored-by: Ryan Gilbert <ryangilbert7926@gmail.com> Co-authored-by: Chris Gerber <csgerber@gmail.com>
disambuguates -> disambiguates
…d protocols (#256) @murrlincoln Co-authored-by: Lincoln Murr <lincoln.murr@coinbase.com>
* add moonwell action providers Signed-off-by: Elliot <elliotfriedman3@gmail.com> * update: lint, update nomenclature, fix tests, add new constants Signed-off-by: Elliot <elliotfriedman3@gmail.com> --------- Signed-off-by: Elliot <elliotfriedman3@gmail.com>
* Update README.md * Update README.md * Add files via upload * Update README.md * Update README.md
Co-authored-by: Christopher Gerber <christopher.gerber@coinbase.com> Co-authored-by: Ryan Gilbert <ryangilbert7926@gmail.com>
🟡 Heimdall Review Status
|
|
Looks good, hope this is merged! |
|
Hi @pcminh0505, thanks for the contribution! Looks pretty good, please rebase against main, then I will do some testing. A few initial comments:
|
| }) | ||
| async getPortfolioOverview(args: z.infer<typeof GetWalletPortfolioSchema>): Promise<string> { | ||
| try { | ||
| const address = args.walletAddress || ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should fall back to walletProvider.address as states in schema. same for other action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @phdargen , imo it should be wallet-free tool (llke OpenSea). I already have an error check for Invalid wallet address below. My initial intention for Zerion API is portfolio check (with DeFi/fungible positions) for any wallet
| @@ -0,0 +1,182 @@ | |||
| /** | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove l1-9 to fit existing code style
| * Replace or modify this with your actual action. | ||
| * | ||
| * @description | ||
| * This is a template action that demonstrates the basic structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace template description with actual action description
|
Hi @pcminh0505, thanks for the update! Unfortunately the rebasing didnt work out as intended, it shows 71 commits now and hundreds of changed files. Could you please try to clean-up the commit history? Also your first 2 commits are still unsigned |
Description
get_portfolio_overview: Get aggregated USD balance of a wallet addressget_fungible_positions: Get aggregated token positions (wallet and DeFi) of a wallet addressRequirement: Zerion API key
Example
get_portfolio_overviewget_fungible_positionsTests
Checklist
A couple of things to include in your PR for completeness: