-
Notifications
You must be signed in to change notification settings - Fork 309
[code_review] Do not use new examples in the experimental environment #5002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The evaluation results:
This can be compared to #4984 (comment). It seems that the results did not improve as much as was shown in the approved examples PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the use of new examples in the experimental environment by adding an optional time filter for generated comment examples and issuing a warning when running in an experimental environment.
- Introduces a new attribute (must_range) to the QueryFilter for handling range queries.
- Adds an experimental environment flag that filters examples based on patch creation date and prints a warning.
- Updates several function signatures to accept an optional created_before parameter for filtering comment examples.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
bugbug/vectordb.py | Adds the must_range filter support in QueryFilter. |
bugbug/tools/code_review.py | Introduces experimental environment handling and updates function signatures to include an optional created_before parameter. |
…st_range' attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pity the improvement is gone :(
Resolves #4995