[code_review] Add approved generated comments as examples in the prompt #4984
+97
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhaibmujahid
force-pushed
the
approved-generated
branch
3 times, most recently
from
cc258af to
958a137
Compare
suhaibmujahid
force-pushed
the
approved-generated
branch
from
958a137 to
f31b5f9
Compare
This helps with the schema changes.
suhaibmujahid
force-pushed
the
approved-generated
branch
from
f31b5f9 to
b92e68c
Compare
|
Here is the report: This can be compared to #4966 (comment): The numbers look better overall. However, there is a chance of bias since the examples could come from revisions in the evaluation dataset. |
suhaibmujahid
commented
Apr 25, 2025
marco-c
reviewed
Apr 29, 2025
marco-c
reviewed
Apr 29, 2025
marco-c
reviewed
Apr 29, 2025
marco-c
reviewed
Apr 29, 2025
marco-c
reviewed
Apr 29, 2025
marco-c
previously approved these changes
Apr 29, 2025
Co-authored-by: Marco Castelluccio <mcastelluccio@mozilla.com>
marco-c
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4320