Skip to content

Qt5 6 #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Qt5 6 #3493

wants to merge 1 commit into from

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Jun 4, 2025

Description

the patch allows compilation with both qt5 and qt6

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rhaschke
Copy link
Contributor

rhaschke commented Jun 4, 2025

Is this a backport of moveit/moveit#3582? If so, why didn't you declare it like this?
If not, why not? The PR was already reviewed and we should not do work twice.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@716f734). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main   #3493   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?     571           
  Lines           ?   51994           
  Branches        ?    6748           
======================================
  Hits            ?       0           
  Misses          ?   51994           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mosfet80 mosfet80 force-pushed the QT5-6 branch 2 times, most recently from 9df8913 to dc039e2 Compare June 25, 2025 13:25
Fixed a rviz_default_plugin compilation error when using qt6.
The error is silent if you have qt5 and qt6 installed

fix qt6 compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants