Skip to content

Commit 9df8913

Browse files
committed
fix compile with qt6
Fixed a rviz_default_plugin compilation error when using qt6. The error is silent if you have qt5 and qt6 installed
1 parent 631e7ba commit 9df8913

File tree

6 files changed

+30
-23
lines changed

6 files changed

+30
-23
lines changed

moveit_ros/visualization/CMakeLists.txt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,12 @@ find_package(rviz_ogre_vendor REQUIRED)
3737
# Finds Boost Components
3838
include(ConfigExtras.cmake)
3939

40+
4041
# Qt Stuff
41-
find_package(Qt5 ${rviz_QT_VERSION} REQUIRED Core Widgets)
42-
set(QT_LIBRARIES Qt5::Widgets)
43-
# Delegate to QT5 macro
44-
macro(QT_WRAP_UI)
45-
qt5_wrap_ui(${ARGN})
46-
endmacro()
42+
find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Test Widgets)
43+
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Test Widgets)
44+
45+
4746

4847
set(CMAKE_INCLUDE_CURRENT_DIR ON)
4948
set(CMAKE_AUTOMOC ON)
@@ -116,7 +115,7 @@ install(
116115
DESTINATION include/moveit_ros_visualization)
117116

118117
ament_export_targets(moveit_ros_visualizationTargets HAS_LIBRARY_TARGET)
119-
ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS})
118+
ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS} Qt${QT_VERSION_MAJOR} )
120119

121120
ament_package(CONFIG_EXTRAS ConfigExtras.cmake)
122121

moveit_ros/visualization/motion_planning_rviz_plugin/CMakeLists.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1+
find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets)
2+
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets)
3+
14
set(HEADERS
25
include/moveit/motion_planning_rviz_plugin/motion_planning_display.hpp
36
include/moveit/motion_planning_rviz_plugin/motion_planning_frame.hpp
47
include/moveit/motion_planning_rviz_plugin/motion_planning_frame_joints_widget.hpp
58
include/moveit/motion_planning_rviz_plugin/motion_planning_param_widget.hpp
69
include/moveit/motion_planning_rviz_plugin/interactive_marker_display.hpp)
7-
qt5_wrap_ui(UIC_FILES src/ui/motion_planning_rviz_plugin_frame.ui
10+
qt_wrap_ui(UIC_FILES src/ui/motion_planning_rviz_plugin_frame.ui
811
src/ui/motion_planning_rviz_plugin_frame_joints.ui)
912

1013
include_directories(${CMAKE_CURRENT_BINARY_DIR})
@@ -38,7 +41,7 @@ ament_target_dependencies(
3841
moveit_ros_warehouse
3942
rviz2
4043
rviz_ogre_vendor
41-
Qt5
44+
Qt${QT_VERSION_MAJOR}
4245
pluginlib)
4346
target_include_directories(moveit_motion_planning_rviz_plugin_core
4447
PRIVATE "${OGRE_PREFIX_DIR}/include")

moveit_ros/visualization/planning_scene_rviz_plugin/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets)
2+
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets)
13
add_library(
24
moveit_planning_scene_rviz_plugin_core SHARED
35
src/planning_scene_display.cpp src/background_processing.cpp
@@ -27,7 +29,7 @@ add_library(moveit_planning_scene_rviz_plugin SHARED src/plugin_init.cpp)
2729
set_target_properties(moveit_planning_scene_rviz_plugin
2830
PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
2931
target_link_libraries(moveit_planning_scene_rviz_plugin
30-
moveit_planning_scene_rviz_plugin_core Qt5::Widgets)
32+
moveit_planning_scene_rviz_plugin_core Qt${QT_VERSION_MAJOR}::Widgets)
3133
ament_target_dependencies(moveit_planning_scene_rviz_plugin pluginlib
3234
rviz_ogre_vendor)
3335
target_include_directories(moveit_planning_scene_rviz_plugin

moveit_ros/visualization/rviz_plugin_render_tools/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets)
2+
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets)
3+
14
set(HEADERS
25
include/moveit/rviz_plugin_render_tools/octomap_render.hpp
36
include/moveit/rviz_plugin_render_tools/planning_link_updater.hpp
@@ -24,7 +27,7 @@ add_library(
2427
set_target_properties(moveit_rviz_plugin_render_tools
2528
PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}")
2629

27-
target_link_libraries(moveit_rviz_plugin_render_tools Qt5::Widgets)
30+
target_link_libraries(moveit_rviz_plugin_render_tools Qt${QT_VERSION_MAJOR}::Widgets)
2831

2932
ament_target_dependencies(
3033
moveit_rviz_plugin_render_tools

moveit_setup_assistant/moveit_setup_assistant/CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,17 @@ find_package(Boost REQUIRED program_options)
1212
find_package(moveit_setup_framework REQUIRED)
1313
find_package(moveit_setup_srdf_plugins REQUIRED)
1414
find_package(pluginlib REQUIRED)
15-
find_package(Qt5Core REQUIRED)
16-
find_package(Qt5Widgets REQUIRED)
15+
find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets)
16+
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets)
1717
find_package(rclcpp REQUIRED)
1818

1919
set(THIS_PACKAGE_INCLUDE_DEPENDS
2020
ament_index_cpp
2121
moveit_setup_framework
2222
moveit_setup_srdf_plugins
2323
pluginlib
24-
Qt5Core
25-
Qt5Widgets
24+
Qt${QT_VERSION_MAJOR}Core
25+
Qt${QT_VERSION_MAJOR}Widgets
2626
rclcpp)
2727

2828
# Header files that need Qt Moc pre-processing for use with Qt signals, etc:
@@ -32,7 +32,7 @@ set(HEADERS include/moveit_setup_assistant/navigation_widget.hpp
3232
set(CMAKE_AUTOMOC ON)
3333
add_definitions(-DQT_NO_KEYWORDS)
3434

35-
qt5_wrap_cpp(MOC_FILES ${HEADERS})
35+
qt${QT_VERSION_MAJOR}_wrap_cpp(MOC_FILES ${HEADERS})
3636

3737
add_executable(
3838
moveit_setup_assistant src/main.cpp src/setup_assistant_widget.cpp

moveit_setup_assistant/moveit_setup_framework/CMakeLists.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ find_package(fmt REQUIRED)
1212
find_package(moveit_core REQUIRED)
1313
find_package(moveit_ros_planning REQUIRED)
1414
find_package(moveit_ros_visualization REQUIRED)
15-
find_package(Qt5Core REQUIRED)
16-
find_package(Qt5Widgets REQUIRED)
15+
find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Widgets)
16+
find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Widgets)
1717
find_package(pluginlib REQUIRED)
1818
find_package(rclcpp REQUIRED)
1919
find_package(rviz_common REQUIRED)
@@ -23,7 +23,7 @@ find_package(urdf REQUIRED)
2323

2424
set(CMAKE_INCLUDE_CURRENT_DIR ON)
2525

26-
qt5_wrap_cpp(
26+
qt_wrap_cpp(
2727
MOC_FILES
2828
include/moveit_setup_framework/qt/helper_widgets.hpp
2929
include/moveit_setup_framework/qt/setup_step_widget.hpp
@@ -54,8 +54,8 @@ ament_target_dependencies(
5454
moveit_ros_planning
5555
moveit_ros_visualization
5656
pluginlib
57-
Qt5Core
58-
Qt5Widgets
57+
Qt${QT_VERSION_MAJOR}Core
58+
Qt${QT_VERSION_MAJOR}Widgets
5959
rclcpp
6060
rviz_common
6161
rviz_rendering
@@ -80,8 +80,8 @@ install(
8080

8181
ament_export_dependencies(fmt)
8282
ament_export_dependencies(rclcpp)
83-
ament_export_dependencies(Qt5Core)
84-
ament_export_dependencies(Qt5Widgets)
83+
ament_export_dependencies(Qt${QT_VERSION_MAJOR}Core)
84+
ament_export_dependencies(Qt${QT_VERSION_MAJOR}Widgets)
8585
ament_export_dependencies(moveit_common)
8686
ament_export_dependencies(moveit_core)
8787
ament_export_dependencies(moveit_ros_planning)

0 commit comments

Comments
 (0)