Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api-calls): Replaces throwing api responses for the search with optionals #113

Draft
wants to merge 30 commits into
base: refactor(api-calls)_readability-and-maintainability-2
Choose a base branch
from

Commits on Sep 27, 2024

  1. refactor(submodel visualizations): adjust submodel visualizations to …

    …make them more easily extendable (#99)
    
    # Description
    
    This makes it easier so create your own submodel visualizations
    
    ## Type of change
    
    Please delete options that are not relevant.
    
    -   [x] Minor change (non-breaking change, e.g. documentation adaption)
    -   [ ] Bug fix (non-breaking change which fixes an issue)
    -   [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that causes existing functionality
    to not work as expected)
    
    # Checklist:
    
    -   [x] I have performed a self-review of my code
    - [x] I have commented my code, particularly in hard-to-understand areas
    -   [ ] I have made corresponding changes to the documentation
    -   [x] My changes generate no new warnings
    -   [ ] I have added tests that prove my fix or my feature works
    -   [ ] New and existing tests pass locally with my changes
    -   [x] My changes contain no console logs
    Xmilofranke authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    511ced7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a378af1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    98039ca View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. refactor(ARMTemplate): Adjust Mnestix Api configuration (#98)

    # Description
    
    - Adjust Mnestix Api configuration
    
    Fixes # (Issue)
    
    ## Type of change
    
    Please delete options that are not relevant.
    
    -   [x] Minor change (non-breaking change, e.g. documentation adaption)
    - 
    # Checklist:
    
    -   [x] I have performed a self-review of my code
    - [x] I have commented my code, particularly in hard-to-understand areas
    -   [ ] I have made corresponding changes to the documentation
    -   [x] My changes generate no new warnings
    -   [ ] I have added tests that prove my fix or my feature works
    -   [x] New and existing tests pass locally with my changes
    -   [x] My changes contain no console logs
    pawel-baran-se authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e2d89f5 View commit details
    Browse the repository at this point in the history
  2. fix(submodel overview card): fix skeleton for submodelsoverview card (#…

    …100)
    
    # Description
    
    This fixes the skeleton in the submodel overview card
    
    Fixes #50
    
    ## Type of change
    
    Please delete options that are not relevant.
    
    -   [ ] Minor change (non-breaking change, e.g. documentation adaption)
    -   [x] Bug fix (non-breaking change which fixes an issue)
    -   [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that causes existing functionality
    to not work as expected)
    
    # Checklist:
    
    -   [x] I have performed a self-review of my code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    -   [ ] I have made corresponding changes to the documentation
    -   [x] My changes generate no new warnings
    -   [ ] I have added tests that prove my fix or my feature works
    -   [x] New and existing tests pass locally with my changes
    -   [x] My changes contain no console logs
    
    ---------
    
    Co-authored-by: melanie.gail <melanie.gail@xitaso.com>
    Xmilofranke and GailMelanie authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8fbc92c View commit details
    Browse the repository at this point in the history
  3. fix(compare-view): images in comparison view now redirect to the corr…

    …ect aas detail page
    
    # Description
    
    When clicking on an AAS image in compare view, we now set the AAS
    context, before redirecting.
    Also added a simple E2E test.
    
    Fixes # (MNES-1227)
    
    ## Type of change
    
    -   [x] Bug fix (non-breaking change which fixes an issue)
    
    # Checklist:
    
    -   [x] I have performed a self-review of my code
    - [x] I have commented my code, particularly in hard-to-understand areas
    -   [ ] I have made corresponding changes to the documentation
    -   [x] My changes generate no new warnings
    -   [x] I have added tests that prove my fix or my feature works
    -   [x] New and existing tests pass locally with my changes
    -   [x] My changes contain no console logs
    JonathanXITASO authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    991375e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #101 from mnestix/fix-document-visualization-image…

    …-not-shown
    
    fix(document visualization): image not correctly loaded
    XAndreJentzsch authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ac66878 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    170aa9c View commit details
    Browse the repository at this point in the history
  2. fix(StyledImageWithFallback loading): handle slow loading and error (#…

    …102)
    
    # Description
     
    This PR adds an additional loading state to the StyledImageWithFallback.
    While loading the image now the skeleton animation is visible.
    
    ## Type of change
    -   [x] Minor change (non-breaking change, e.g. documentation adaption)
    
    # Checklist:
    -   [x] I have performed a self-review of my code
    -   [x] My changes generate no new warnings
    -   [x] My changes contain no console logs
    XAndreJentzsch authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    76e7b8b View commit details
    Browse the repository at this point in the history
  3. Test(custom submod viz) change suggestions (#104)

    # Description
    
    This MR contains refactoring and minor improvements of the code for
    implementing custom submodels that occured as we tested the finished
    story.
    
    The wiki on how to include custom submodel visualizations was updated as
    well and can/should be read here:
    https://github.com/mnestix/mnestix-browser/wiki/How-to-create-custom-submodel-visualizations
    
    Fixes # (Issue)
    
    ## Type of change
    
    Please delete options that are not relevant.
    
    -   [ x] Minor change (non-breaking change, e.g. documentation adaption)
    -   [ ] Bug fix (non-breaking change which fixes an issue)
    -   [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that causes existing functionality
    to not work as expected)
    
    # Checklist:
    
    -   [x ] I have performed a self-review of my code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    -   [ ] I have made corresponding changes to the documentation
    -   [ ] My changes generate no new warnings
    -   [ ] I have added tests that prove my fix or my feature works
    -   [x ] New and existing tests pass locally with my changes
    -   [x ] My changes contain no console logs
    FranzXitaso authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    91252cd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5740430 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. minor(version): version bump to 1.2.1 (#106)

    # Description
    
    Version bump to 1.2.1
    
    ## Type of change
    
    Please delete options that are not relevant.
    
    -   [x] Minor change (non-breaking change, e.g. documentation adaption)
    -   [ ] Bug fix (non-breaking change which fixes an issue)
    -   [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that causes existing functionality
    to not work as expected)
    Xmilofranke authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5e4e45f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Introduce new mnestixFetch implementation which does not throw on fai…

    …lure
    Frederik Schlüter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2a47d63 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    8759e39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba904b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    5bff4eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    728a2b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    43127d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb97d32 View commit details
    Browse the repository at this point in the history
  3. Modify remaining functions in RepositorySearchService to use the ApiR…

    …esponseWrapper
    Frederik Schlüter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5b3c0b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    58f1968 View commit details
    Browse the repository at this point in the history
  5. MNES-1246: Add ApiResponseWrapper for Discovery

    Frederik Schlüter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5125ec2 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    f131209 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4abfe2 View commit details
    Browse the repository at this point in the history
  3. Refactor(dev experience) speed up dev mode (#111)

    # Description
    
    Please include a summary of the changes and link the related github
    issue.
    Please include relevant motivation and context.
    
    Fixes # (Issue)
    
    ## Type of change
    
    Please delete options that are not relevant.
    
    -   [ ] Minor change (non-breaking change, e.g. documentation adaption)
    -   [ ] Bug fix (non-breaking change which fixes an issue)
    -   [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that causes existing functionality
    to not work as expected)
    
    # Checklist:
    
    -   [ ] I have performed a self-review of my code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    -   [ ] I have made corresponding changes to the documentation
    -   [ ] My changes generate no new warnings
    -   [ ] I have added tests that prove my fix or my feature works
    -   [ ] New and existing tests pass locally with my changes
    -   [ ] My changes contain no console logs
    GailMelanie authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    389ebc3 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge remote-tracking branch 'origin/refactor(api-calls)_readability-…

    …and-maintainability-2' into refactor(api-calls)_meaningful_return_objects
    Frederik Schlüter committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    552bac5 View commit details
    Browse the repository at this point in the history
  2. MNES-1246: Fix CompareViewContext

    Frederik Schlüter committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5f67ac0 View commit details
    Browse the repository at this point in the history
  3. MNES-1246: Fix CompareViewContext final

    Frederik Schlüter committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    42a3073 View commit details
    Browse the repository at this point in the history
  4. MNES-1246: refactor CompareViewContext

    Frederik Schlüter committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    35f9962 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/dev' into refactor(api-calls)_me…

    …aningful_return_objects
    Frederik Schlüter committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7b3078e View commit details
    Browse the repository at this point in the history