refactor(api-calls): Replaces throwing api responses for the search with optionals #113
+1,269
−2,511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make them more easily extendable (#99) # Description This makes it easier so create your own submodel visualizations ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [x] My changes contain no console logs
# Description - Adjust Mnestix Api configuration Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) - # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs
…100) # Description This fixes the skeleton in the submodel overview card Fixes #50 ## Type of change Please delete options that are not relevant. - [ ] Minor change (non-breaking change, e.g. documentation adaption) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs --------- Co-authored-by: melanie.gail <melanie.gail@xitaso.com>
…ect aas detail page # Description When clicking on an AAS image in compare view, we now set the AAS context, before redirecting. Also added a simple E2E test. Fixes # (MNES-1227) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs
…-not-shown fix(document visualization): image not correctly loaded
…102) # Description This PR adds an additional loading state to the StyledImageWithFallback. While loading the image now the skeleton animation is visible. ## Type of change - [x] Minor change (non-breaking change, e.g. documentation adaption) # Checklist: - [x] I have performed a self-review of my code - [x] My changes generate no new warnings - [x] My changes contain no console logs
# Description This MR contains refactoring and minor improvements of the code for implementing custom submodels that occured as we tested the finished story. The wiki on how to include custom submodel visualizations was updated as well and can/should be read here: https://github.com/mnestix/mnestix-browser/wiki/How-to-create-custom-submodel-visualizations Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [ x] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [x ] New and existing tests pass locally with my changes - [x ] My changes contain no console logs
# Description Version bump to 1.2.1 ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected)
# Description Please include a summary of the changes and link the related github issue. Please include relevant motivation and context. Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [ ] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [ ] My changes contain no console logs
…and-maintainability-2' into refactor(api-calls)_meaningful_return_objects
…aningful_return_objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All functions which make api calls return optionals instead of throwing
Fixes # (Issue)
Type of change
Please delete options that are not relevant.
Checklist: