refactor(submodel visualizations): adjust submodel visualizations to make them more easily extendable #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description This introduces a mapping between semantic ids and submodels/submodel elements that is easily extandable. ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [x] My changes contain no console logs
github-actions
bot
requested review from
fleanegan,
FranzXitaso,
GailMelanie,
hofermo,
JonathanXITASO,
NilsXitaso,
pawel-baran-se,
XAlinaGS and
XAndreJentzsch
pawel-baran-se
approved these changes
Sep 27, 2024
JonathanXITASO
approved these changes
Sep 27, 2024
src/app/[locale]/viewer/_components/submodel-elements/SubmodelElementMapping.ts
Show resolved
Hide resolved
Xmilofranke
deleted the
MNES-1144-extandable-submodel-visualizations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it easier so create your own submodel visualizations
Type of change
Please delete options that are not relevant.
Checklist: