Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(StyledImageWithFallback loading): handle slow loading and error #102

Merged
merged 6 commits into from
Oct 2, 2024
Merged

fix(StyledImageWithFallback loading): handle slow loading and error #102

merged 6 commits into from
Oct 2, 2024

Conversation

XAndreJentzsch
Copy link
Contributor

@XAndreJentzsch XAndreJentzsch commented Sep 30, 2024 •
edited
Loading

Description

This PR adds an additional loading state to the StyledImageWithFallback.
While loading the image now the skeleton animation is visible.

Fixes # (Issue)

Type of change

Please delete options that are not relevant.

  • Minor change (non-breaking change, e.g. documentation adaption)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix or my feature works
  • New and existing tests pass locally with my changes
  • My changes contain no console logs

@XAndreJentzsch XAndreJentzsch changed the title Mnes 1166 handle slow loading and error fix(StyledImageWithFallback loading): handle slow loading and error Sep 30, 2024
@XAndreJentzsch XAndreJentzsch merged commit 76e7b8b into dev Oct 2, 2024
2 checks passed
@XAndreJentzsch XAndreJentzsch deleted the MNES-1166-handle-slow-loading-and-error branch October 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GailMelanie GailMelanie GailMelanie approved these changes

@JonathanXITASO JonathanXITASO JonathanXITASO approved these changes

@fleanegan fleanegan Awaiting requested review from fleanegan

@FranzXitaso FranzXitaso Awaiting requested review from FranzXitaso

@hofermo hofermo Awaiting requested review from hofermo

@NilsXitaso NilsXitaso Awaiting requested review from NilsXitaso

@pawel-baran-se pawel-baran-se Awaiting requested review from pawel-baran-se

@XAlinaGS XAlinaGS Awaiting requested review from XAlinaGS

@Xmilofranke Xmilofranke Awaiting requested review from Xmilofranke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAndreJentzsch @GailMelanie @JonathanXITASO