[opentelemetry-cpp] update to 1.12.0 #33983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwang118
added
info:internal
BillyONeal
previously requested changes
Oct 3, 2023
Adela0814
previously approved these changes
Oct 10, 2023
BillyONeal
removed
the
info:reviewed
…118/vcpkg into update_opentelemtery-cpp
|
Ping. I selfishly want to use some of the features in opentelemetry-cpp v1.12.0 :) |
OK, check that the latest version upstream is v1.12.0, I will update to the latest version. |
jimwang118
changed the title
dbolduc
reviewed
Oct 18, 2023
Adela0814
suggested changes
Oct 25, 2023
Adela0814
approved these changes
Oct 27, 2023
data-queue
approved these changes
Oct 27, 2023
ScottEllis1
reviewed
Oct 31, 2023
| @@ -39,7 +38,14 @@ | |||
| "otlp": { | |||
| "description": "Whether to include the OpenTelemetry Protocol in the SDK", | |||
| "dependencies": [ | |||
| "protobuf" | |||
There was a problem hiding this comment.
What was the reason for removing this and adding the other features as dependencies? Now gRPC is included if otlp-http is included. I was previously trying to limit the size of the dependencies and I didn't want to include gRPC if I didn't have to. reverting these lines seems to fix my problem. Was this intended?
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33772
otlpbased on upstream PR 2161.opentelemetry-fluentdadds missing header files.use-default-cxx-version.patch and add-missing-include-file.patch.The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.Usage test pass with following triplets: