-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Remove option WITH_OTLP #2161
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
- Coverage 87.17% 87.13% -0.04%
==========================================
Files 166 166
Lines 4777 4777
==========================================
- Hits 4164 4162 -2
- Misses 613 615 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see a small fix on the doc.
Thanks for the fix.
Fixes #1926, #2160.
Changes
Remove
WITH_OTLP
option and raise error on its definition as it causes confusions (see the above issues). Also makeWITH_OTLP_GRPC
as a plain option likeWITH_OTLP_HTTP
.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes