Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove option WITH_OTLP #2161

Merged
merged 7 commits into from
May 31, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes #1926, #2160.

Changes

Remove WITH_OTLP option and raise error on its definition as it causes confusions (see the above issues). Also make WITH_OTLP_GRPC as a plain option like WITH_OTLP_HTTP.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team May 26, 2023 18:31
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #2161 (fc1bbc9) into main (0eca570) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2161      +/-   ##
==========================================
- Coverage   87.17%   87.13%   -0.04%     
==========================================
  Files         166      166              
  Lines        4777     4777              
==========================================
- Hits         4164     4162       -2     
- Misses        613      615       +2     

see 1 file with indirect coverage changes

CMakeLists.txt Show resolved Hide resolved
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

docker/Dockerfile Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see a small fix on the doc.

Thanks for the fix.

@marcalff marcalff changed the title Remove option WITH_OTLP [BUILD] Remove option WITH_OTLP May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] CMake option WITH_OTLP_GRPC not predictable, sometime not displayed.
4 participants