Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] WITH_OTLP deprecated but removing it breaks the build #2160

Closed
h-vetinari opened this issue May 26, 2023 · 3 comments
Closed

[BUILD] WITH_OTLP deprecated but removing it breaks the build #2160

h-vetinari opened this issue May 26, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@h-vetinari
Copy link

Even though the option WITH_OTLP is deprecated, it's still used in several places throughout otel (including CI and docker).

Furthermore, following the deprecation warning and replacing it by WITH_OTLP_GRPC and/or WITH_OTLP_HTTP will not work, since WITH_OTLP is used here to determine whether exporters/otlp is included (which is where opentelemetry_exporter_otlp_{grpc,http} are built).
@ThomsonTan
Copy link
Contributor

Thanks for reporting. I'll remove WITH_OTLP which should fix this.

@marcalff marcalff added the bug Something isn't working label May 26, 2023
@marcalff marcalff changed the title BUG: WITH_OTLP deprecated but removing it breaks the build [BUILD] WITH_OTLP deprecated but removing it breaks the build May 26, 2023
@marcalff
Copy link
Member

Related to #1926, which still needs to be implemented.

@ThomsonTan ThomsonTan mentioned this issue May 26, 2023
Merged
3 tasks
@marcalff
Copy link
Member

Fixed by PR #2161

@itskingori itskingori mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThomsonTan @marcalff @h-vetinari