Make vcpkg.json comment multiline #5175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that microsoft/vcpkg#34877 is fixed, we can format
vcpkg.json
comment as multi-line.This way, it is better visible, and it aligns with the existing
portfile.cmake
comment, which is also multi-line:azure-sdk-for-cpp/sdk/core/azure-core/vcpkg/portfile.cmake
Lines 4 to 5 in 37e1952
I am updating the vcpkg commit SHA to microsoft/vcpkg@43cf47e, because that is the commit which updates vcpkg to the
2023-11-16
release -vcpkg-tool
release which contains bugfix for microsoft/vcpkg#34877: https://github.com/microsoft/vcpkg-tool/releases/tag/2023-11-16--
@LarryOsterman, I am adding
#include <opentelemetry/sdk/trace/recordable.h>
for thesdk/core/azure-core-tracing-opentelemetry/test/ut/test_exporter.hpp
. It only updates the unit test code and does not require a package release (unit tests are not compiled when our SDK is being installed as vcpkg package). It is not a breaking change either. Everything should compile with both the previous version ofopentelemetry-cpp
, and the new one.The reason is - vcpkg now has an updated version of
opentelemetry-cpp
-1.12.0
- microsoft/vcpkg#33983.And one of the commits which went into that version, was "
[SDK] Header files cleanup, use forward declarations
", which has specifically dropped#include <opentelemetry/sdk/trace/recordable.h>
line from theopentelemetry/sdk/trace/exporter.h
, which is the only header file that we were including before at that place. But it is no longer sufficient:open-telemetry/opentelemetry-cpp@cfcda57#diff-c44d1944597823ab10bd389630f778367fb19eaac5ae68cdefa5e8d5f71a5783L9