Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Traceviewer screens are not recorded well when using constructable stylesheets #7085

Closed
Tallyb opened this issue Jun 12, 2021 · 3 comments · Fixed by #7084 or #8886
Closed

[BUG] Traceviewer screens are not recorded well when using constructable stylesheets #7085

Tallyb opened this issue Jun 12, 2021 · 3 comments · Fixed by #7084 or #8886
Assignees
@dgozman

Comments

@Tallyb
Copy link

Tallyb commented Jun 12, 2021

Context:

  • Playwright Version: 12.1.1
  • Operating System: mac
  • Node.js version: 16
  • Browser: Chromium
  • Extra: [any specific details about your environment]

when running trace viewer on a site built with stencil-js, the html snapshots are displayed incorrectly.
This is due to the use of constructable stylesheet.
@JoelEinbinder JoelEinbinder self-assigned this Jun 14, 2021
@JoelEinbinder JoelEinbinder mentioned this issue Jun 14, 2021
Merged
JoelEinbinder added a commit that referenced this issue Jun 17, 2021
@JoelEinbinder
fix(snapshotter): support constructed CSSStyleSheet
10a82f8 
Fixes #7085
This was referenced Jun 17, 2021
Closed
Closed
aslushnikov pushed a commit to aslushnikov/playwright that referenced this issue Jun 26, 2021
@JoelEinbinder @aslushnikov
cherry-pick(release-1.12): support constructed CSSStyleSheet
84a0fb0 
PR microsoft#7084 SHA 10a82f8

Fixes microsoft#7085
@aslushnikov aslushnikov mentioned this issue Jun 26, 2021
Merged
aslushnikov added a commit that referenced this issue Jun 26, 2021
@aslushnikov @JoelEinbinder
cherry-pick(release-1.12): support constructed CSSStyleSheet (#7334)
c25e00b 
PR #7084 SHA 10a82f8

Fixes #7085

Co-authored-by: Joel Einbinder <joel.einbinder@gmail.com>
@aaltat aaltat mentioned this issue Jun 28, 2021
Closed
@Tallyb
Copy link
Author

Tallyb commented Jun 28, 2021

Still exists in 1.12.3

@mxschmitt mxschmitt reopened this Jun 28, 2021
@mxschmitt mxschmitt added v1.14 and removed v1.13 labels Jul 12, 2021
@aslushnikov aslushnikov added v1.15 and removed v1.14 labels Aug 11, 2021
@dgozman dgozman assigned dgozman and unassigned JoelEinbinder Sep 10, 2021
@dgozman
Copy link
Contributor

dgozman commented Sep 10, 2021

@Tallyb Does this still repro for you? I am trying to reproduce this on sites like https://stenciljs.com/, but it seems to work.

@Tallyb
Copy link
Author

Tallyb commented Sep 13, 2021

@dgozman - It still happens. I believe the stencil.js site does not contain web components with shadow dom.
You can run on our website (app.yoobic.com. You should encounter the issue on the login page so no credentials are needed).

@dgozman dgozman mentioned this issue Sep 14, 2021
Merged
@mxschmitt mxschmitt mentioned this issue Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@aslushnikov @JoelEinbinder @Tallyb @dgozman @mxschmitt