fix(snapshot): render adoptedStyleSheets used in more than one node #8886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
force-pushed
the
snapshot_render_same_style_sheet
branch
from
3ffd416
to
32f0092
Compare
dgozman
reviewed
Sep 14, 2021
| (root as any).adoptedStyleSheets = [sheet2]; | ||
| document.body.appendChild(div); | ||
|
|
||
| for (const element of [document.createElement('div'), document.createElement('span')]) { |
There was a problem hiding this comment.
Let's also cover CSSStyleSheet.replace{,Sync} methods.
dgozman
approved these changes
Sep 15, 2021
mxschmitt
pushed a commit
to mxschmitt/playwright
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes adopted style sheets reference other style sheets in the same document.
Fixes #7085.