Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace viewer doesn't show formatted screen on main screen #1096

Closed
emakaay opened this issue Jun 22, 2021 · 14 comments
Closed

Trace viewer doesn't show formatted screen on main screen #1096

emakaay opened this issue Jun 22, 2021 · 14 comments

Comments

@emakaay
Copy link

emakaay commented Jun 22, 2021

Describe the bug
I took a first look at the show-trace option of rfbrowser. It has great potential.

After starting the show-trace I'm presented with a screen with 4 parts

  1. top, containing timeline with formatted screenshots
  2. left, all clicks/fills go to executed during test
  3. right, all resource and network activity

That's all great.

The problem is with the main screen, which should contain the FORMATTED screen at that point in time. Problem is that no formatting seems to take place. Everything is below each other: menu, several tables. forms etc. stylesheets etc and coloring is not applied. The rest of the show-trace app seems to work as expected

I can't share pictures of this unfortunately, but I was wondering if something can be done to get the main screen formatted. Now the point were a click is applied is screwed up (or doesn't point to the correct point).

This could be caused by local network restrictions, but I was under the impression that all resources to format the trace, were in the trace.zip

To Reproduce
every "rfbrowser show-trace F

Expected behavior
I expected the main screen to look like: "https://www.youtube.com/watch?v=Zutt7N6VvcU" when clicked on actions

Screenshots
The mainscreen, but no formatting of coloring on the web page
image

Desktop (please complete the following information):

  • robotframework 5.1.1
  • playwright 12.2
@emakaay
Copy link
Author

emakaay commented Jun 22, 2021

Perhaps this problem is already fixed with new version of playwright.....

microsoft/playwright#6985 (comment).

But I don't have access to this @next release to check it

@aaltat
Copy link
Member

aaltat commented Jun 24, 2021

There tracing is based on Playwright and library servers only as thin wrapper on the top. If the UI opens, but is missing something, then it's a bug in the Playwright side, most likely.

Could you share example that demonstrates the problem? Also could you share details about the OS you are using?

@emakaay
Copy link
Author

emakaay commented Jun 24, 2021

I already added an example.
The login page should contain formatting.
Css coloring is missing. Also placement of elements is incorrect.

When looking at dev console several errors are shown that css and js files can't be found(404). But I can't show you that(corporate issue)

@emakaay
Copy link
Author

emakaay commented Jun 24, 2021

Will retry when new version of playwright is available. I can't get the @next version of playwright(corporate issue)

@aaltat
Copy link
Member

aaltat commented Jun 28, 2021

There was a new release from PW side which has fixes on this subject: microsoft/playwright#7085

@emakaay
Copy link
Author

emakaay commented Jun 29, 2021 via email

@aaltat
Copy link
Member

aaltat commented Jun 29, 2021

I can not reproduce the problem. For me the trace viewer looks same as in Playwright docs: https://playwright.dev/docs/trace-viewer

The rfbrowser show-trace command is pretty simple. You could add few print() to to display your environment details and run the same command from your shell. If the problem reproduces then the problem is in the playwright side and you need to report the issue to them.

@aaltat
Copy link
Member

aaltat commented Jul 8, 2021

Did you time to try it out manually from the command line?

@emakaay
Copy link
Author

emakaay commented Jul 10, 2021 via email

@aaltat
Copy link
Member

aaltat commented Jul 22, 2021

New pw release is out, could you retest,

@emakaay
Copy link
Author

emakaay commented Jul 22, 2021 via email

@aaltat
Copy link
Member

aaltat commented Jul 25, 2021

I will close the issue because it looks like a PW side problem. If you feel differently, please tell why.

@aaltat aaltat closed this as completed Jul 25, 2021
@emakaay
Copy link
Author

emakaay commented Aug 9, 2021

opened issue with playwright: microsoft/playwright#8095

@emakaay
Copy link
Author

emakaay commented Oct 3, 2021

tested with robotframework 8.0.2 and playwright 15.1. It's getting better, but still not all problems are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants