Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snapshotter): support constructed CSSStyleSheet #7084

Merged
merged 1 commit into from
Jun 17, 2021
Merged

fix(snapshotter): support constructed CSSStyleSheet #7084

merged 1 commit into from
Jun 17, 2021

Conversation

JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Jun 12, 2021 •
edited
Loading

Fixes #7085

@pavelfeldman
Copy link
Member

I am reading about constructable ss here and it feels like you should dedupe them. It will actually make the code simpler to follow.

The doc is saying that you are supposed to create a bunch of constructable stylesheets and then add them into the adopted collections left and right. I would mimic this spirit in the serialization process:

  • dedupe constructables by reference, serialize them once
  • use your array of stylesheets only on the snapshot itself, not on shadow attrs
  • put the index in that table in the template attributes for hydration

That way you are as scaleable as the web itself.

dgozman
dgozman approved these changes Jun 16, 2021
View reviewed changes
src/server/snapshot/snapshotterInjected.ts Outdated Show resolved Hide resolved
src/server/snapshot/snapshotterInjected.ts Outdated Show resolved Hide resolved
@JoelEinbinder JoelEinbinder merged commit 10a82f8 into microsoft:master Jun 17, 2021
This was referenced Jun 17, 2021
Closed
Closed
aslushnikov pushed a commit to aslushnikov/playwright that referenced this pull request Jun 26, 2021
@JoelEinbinder @aslushnikov
cherry-pick(release-1.12): support constructed CSSStyleSheet
84a0fb0 
PR microsoft#7084 SHA 10a82f8

Fixes microsoft#7085
@aslushnikov aslushnikov mentioned this pull request Jun 26, 2021
Merged
aslushnikov added a commit that referenced this pull request Jun 26, 2021
@aslushnikov @JoelEinbinder
cherry-pick(release-1.12): support constructed CSSStyleSheet (#7334)
c25e00b 
PR #7084 SHA 10a82f8

Fixes #7085

Co-authored-by: Joel Einbinder <joel.einbinder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Traceviewer screens are not recorded well when using constructable stylesheets
3 participants
@JoelEinbinder @pavelfeldman @dgozman