Skip to content

Conversation

@jterry75
Copy link
Contributor

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@jterry75 jterry75 requested a review from jstarks November 28, 2018 23:30
@jterry75 jterry75 merged commit 113ee11 into master Nov 28, 2018
@jterry75
Copy link
Contributor Author

@jstarks - FYI just to check my work but merging for now.

@jterry75 jterry75 deleted the no_serial branch November 28, 2018 23:36
}

if !vmDebugging {
if vmDebugging {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you only need to do this when a COM port is enabled above. So you could move this into the existing if block.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jterry75 did you see this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am submitting another change to move it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants