Minor fixes to shim panic log & create task functions #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to collect shim panic logs during shim delete command does not work in cases when the delete command itself runs into some error. To avoid losing shim panic logs in such cases we log the shim panic logs (if found) as first thing in the delete command. CreateTask function had `wcl` mutex lock that wasn't really being used anywhere, this change removes that. We also don't add a `nil` entry for a new task in the `workloadTasks` map anymore to avoid the shim panic in some cases where a `GetTask` function might be called while we are still in the process of creating the task and haven't updated the nil entry with the actual task struct reference.
ambarve
force-pushed
the
shim_panic_create_pod_fixes
branch
from
07d6812 to
fec8e08
Compare
Contributor
Author
|
I am still not sure if this change will cover all the cases in which we are currently not logging shim panic logs but even after trying out a couple of random panics I am not able to repro a case where shim panics but we don't log it. |
Contributor
Yea I'm not sure I was running into the "Delete failed and then we don't log the panics" bucket for the one I encountered as it was just during ReleaseResources that the panic occurred 😢 I'll try and repro this again |
dcantah
approved these changes
Apr 22, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to collect shim panic logs during shim delete command does not work in cases
when the delete command itself runs into some error. To avoid losing shim panic logs in
such cases we log the shim panic logs (if found) as first thing in the delete command.
CreateTask function had
wclmutex lock that wasn't really being used anywhere, thischange removes that. We also don't add a
nilentry for a new task in theworkloadTasksmap anymore to avoid the shim panic in some cases where a
GetTaskfunction mightbe called while we are still in the process of creating the task and haven't updated the
nil entry with the actual task struct reference.