Get rid of mergemaps functionality for v2 codepaths #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's not a single place we used to set the uvm.Options `AdditionHCSDocumentJSON` field to anything so it was as good as not there already. Just skip the calls entirely and remove the copying of the fields for lateclone scenarios. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Contributor
|
Almost none of my code remains 😢. I would recommend asking Kevin and Lars (kbroas/lreuther) about this, it was there for their needs originally, but not used publicly. Just internally. IIRC, it was for testing some memory thing, but too long ago to be specific. |
Contributor
Author
|
@lowenna I swear it's not on purpose 😭. I do see one mention of it (the environment variable for docker use cases) for reproing some race condition in the OS (8 named pipe mappings are added to the config if curious) but nothing more. I'll ask the leads like you said, I was curious what this was for! |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Get rid of mergemaps functionality for v2 codepaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's not a single place we used to set the uvm.Options
AdditionHCSDocumentJSONfield to anything so it was as good as not there already. Just skip the calls entirely and remove the copying of the fields for lateclone scenarios.I've left in the package and code for v1 (docker) in case anyone out there is actually using it 😃
Signed-off-by: Daniel Canter dcanter@microsoft.com