Add support for tier acl policy #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vikas Bhardwaj <vikasb@microsoft.com>
dcantah
reviewed
May 10, 2021
Comment on lines
+321
to
+322
| fmt.Printf("Failed deleting from defer routine network: %s-%s \n", network.Id, network.Name) | ||
| t.Fatal(err) |
Contributor
There was a problem hiding this comment.
I'd prefer if the error just had all of the information instead of writing to stdout right before. Same for line 333-334
t.Fatalf("failed to cleanup l2bridge network %s-%s: %v", network.Id, network.Name, err)
dcantah
reviewed
May 10, 2021
Comment on lines
+357
to
+359
| } else { | ||
| fmt.Printf("Found endpoint: %s-%s \n", foundEndpoint.Id, foundEndpoint.Name) | ||
| } |
erfrimod
approved these changes
May 10, 2021
Keith-Mange
approved these changes
May 10, 2021
Contributor
|
lgtm |
dcantah
approved these changes
May 12, 2021
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
I don't wanna hold this back for some nit comments on test code so lgtm
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#388, microsoft#389, microsoft#393, microsoft#394, microsoft#395, microsoft#396, microsoft#397, microsoft#398, microsoft#399, microsoft#400, microsoft#401, microsoft#402, microsoft#403, microsoft#404, microsoft#405, microsoft#931, microsoft#973, microsoft#1001, microsoft#1003, microsoft#1004, microsoft#1005, microsoft#1006, microsoft#1007, microsoft#1009, microsoft#1010, microsoft#1012, microsoft#1013, microsoft#1014, microsoft#1015, microsoft#1016, microsoft#1017, microsoft#1019, microsoft#1021, microsoft#1022, microsoft#1024, microsoft#1025, microsoft#1027, microsoft#1028, microsoft#1029, microsoft#1030, microsoft#1031, microsoft#1033
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 28, 2024
Add support for tier acl policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vikas Bhardwaj vikasb@microsoft.com