docs: TabBar の Story を見直し #4949
Merged
+226
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
| export const RegFocusNoBorder = All.bind({}) | ||
| RegFocusNoBorder.play = () => [...Array(4)].forEach((_) => userEvent.tab()) | ||
| export const Boardered = { | ||
| name: 'bordered', |
There was a problem hiding this comment.
[nits]
変数名がそのまま Story 名になってくれるので、基本的には name の明示は不要に見えます。
(変数名は大文字したいって拘りかもしれませんが)
|
途中なのであとでまたレビューしますが、概ねの方針は良さそうです！ |
uknmr
force-pushed
the
improve-TabBar-story
branch
from
f94648c
to
19af74c
Compare
Qs-F
approved these changes
Sep 26, 2024
uknmr
force-pushed
the
improve-TabBar-story
branch
from
19af74c
to
abb7d6d
Compare
s-sasaki-0529
approved these changes
Sep 27, 2024
| tags: ['!autodocs'], | ||
| } | ||
|
|
||
| export const True: StoryObj = { |
There was a problem hiding this comment.
[nits]
細かいですが、StoryObj は T にコンポーネントの型を渡してあげると props が型安全になるので書き心地が良くなります！
export const True: StoryObj<typeof TabBar> = {There was a problem hiding this comment.
e2ee5ca で対応しました!
すべての Story に書くの面倒だなぁ、default に指定した型でよしなにやってほしいなぁ、と思ってました😇
雛形作る時に自動生成させても良さそうですね。
This was referenced Oct 9, 2024
Merged
This was referenced Oct 16, 2024
This was referenced Oct 20, 2024
This was referenced Oct 28, 2024
This was referenced Nov 5, 2024
Merged
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1040
概要
Story のあり方を定義し直し、他の見本となる Story を作ろうとしています。
構成は次の通りです。
TabBar / TabItem のようにサブコンポーネントを持つ場合、コンポーネントごとに作成。
VRT を除いて、Story ごとに表示する状態は一つとしました。
ペアワイズ法の組み合わせ作成は、pict を使いました。
変更内容
確認方法