docs(Chip): Story を見直し #5078
Merged
docs(Chip): Story を見直し #5078
+85
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uknmr
requested review from
misako0927 and
hiroki0525
and removed request for
a team
commit: |
uknmr
commented
Nov 5, 2024
| @@ -5,21 +5,21 @@ type Props = PropsWithChildren<VariantProps<typeof chip> & ComponentPropsWithout | |||
|
|
|||
| const chip = tv({ | |||
| base: [ | |||
| 'smarthr-ui-Chip shr-border-shorthand shr-rounded-full shr-leading-none', | |||
| 'smarthr-ui-Chip', | |||
| 'shr-border-shorthand shr-rounded-full shr-bg-white shr-text-black shr-leading-none', | |||
There was a problem hiding this comment.
disabled=false のスタイルも集結（twMerge の設定見直しにより、明示的に分ける必要がなくなった）
| name: 'size', | ||
| render: (args) => ( | ||
| <Stack align="flex-start"> | ||
| {[undefined, 's'].map((size) => ( |
There was a problem hiding this comment.
size って未定義だとデフォルト s で上書きされちゃうので、見た目上の差異がないように見えました。
Playground 上でも一度チェック入れたら外せなくて、どう指定すればサイズが変わるのかがよくわからなかったです！
There was a problem hiding this comment.
現状 size="s" がデフォルトで、サイズ変更もできないので未定義で使ってもらっても問題ないんですよねぇ。
デフォルトで size="s" がコード上に含まれないようにしてみた & radio → select に変えてみたんですがどうかしら 124d8c3
There was a problem hiding this comment.
👍️ 選択肢がSしかない意図が汲み取れるので良さそうです！
Storybook を見ただけだと、未指定時と挙動が変わらないのが仕様なのか不具合なのかまでは判断できないので、props 自体廃止しちゃっても良いかもですね。
s-sasaki-0529
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1116
概要
#4949 の方針に沿って、Chip の Story を見直しました。
変更内容
確認方法
Storybook や Chromatic で確認してください。