feat(DefinitionList): Composition できるように修正 #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
@uknmr compositionパターンにするなら |
|
@AtsushiM 装飾として dt と dd が一対一になってしまっているので、需要次第だと思いますが需要もここ5年はないので需要が高まってきたら検討で良さそう。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
DefinitionList > DefinitionListItem と Composite できるように修正しました。
ついでに #4949 の方針に沿って、Story を見直しました。
変更内容
確認方法
Storybook や Chromatic で確認してください。