docs: Text の Story を見直し #4995
Merged
docs: Text の Story を見直し #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
uknmr
force-pushed
the
improve-Text-story
branch
from
321030d
to
1b9ea6e
Compare
uknmr
commented
Oct 9, 2024
| title: 'Text（テキスト）/Text/VRT', | ||
| render: (args) => ( | ||
| <Stack gap={0.5}> | ||
| {/* styleType ごとにペアワイズ法で抽出したパターンをあてる */} |
There was a problem hiding this comment.
パターンの数が多く、VRT ですべてが正しくあたっているかどうかの確認はしていません。信じる気持ち。
| }, | ||
| }, | ||
| args: { | ||
| children: 'well-working 労働にまつわる社会課題をなくし、誰もがその人らしく働ける社会をつくる。', |
There was a problem hiding this comment.
英字と日本語、カタカナが混じるような文章がほしいけど暫定。
There was a problem hiding this comment.
italic と whiteSpace は自分たちで定義していない、かつ利用頻度が少ないので除外しました。
weight も定義していませんが、利用頻度を鑑みて含めました。
| <Text {...args} whiteSpace="pre-wrap" /> | ||
| </Stack> | ||
| ), | ||
| } |
There was a problem hiding this comment.
ここ、デフォルトのテキストや画面サイズだと違いがまったくわからないので悩ましいですね 🤔
個別に幅を縮めた親要素でラップして折り返しの挙動の違いを見れるようにするとかしても良いかもですが、まぁCSS標準のプロパティなので伝わるから良いかなぁ。
There was a problem hiding this comment.
ウィンドウ幅を狭めて別 Story で VRT 取るのは嫌だなぁと思ってたんですが、幅を固定して改行含めるだけで少しイメージできるやつが作れますね!
対応しました!! 881e51a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1080
概要
#4949 の方針に沿って、Text の Story を見直しました。
変更内容
確認方法
Storybook や Chromatic で確認してください。