Add 1.28 team member to sig-release YAML #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/release
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
+1, this was not required on the 1.27 cycle |
Thanks for confirming @neoaggelos. |
k8s-ci-robot
added
the
lgtm
saschagrunert
approved these changes
May 17, 2023
k8s-ci-robot
added
the
approved
saschagrunert
suggested changes
May 17, 2023
There was a problem hiding this comment.
Ah yeah let's fix that before:
config_test.go:272: The following members of team milestone-maintainers are not Kubernetes org members: kasambx, salehsedghpour
config_test.go:272: The following members of team release-team are not Kubernetes org members: hailkomputer, kasambx, moficodes, salehsedghpour, zelenushechka
config_test.go:272: The following members of team release-team-docs are not Kubernetes org members: adminturneddevops, vibhorchinda
config_test.go:272: The following members of team release-team-enhancements are not Kubernetes org members: kasambx, salehsedghpour
config_test.go:272: The following members of team release-team-release-notes are not Kubernetes org members: muddapu, rashansmith
config_test.go:272: The following members of team ci-signal are not Kubernetes org members: amotul-raheem, mansikulkarni96
config_test.go:272: The following members of team release-team-bug-triage are not Kubernetes org members: hailkomputer, moficodes, zelenushechka
config_test.go:272: The following members of team release-team-comms are not Kubernetes org members: krol, mashby2022, thschue
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
removed
the
lgtm
|
Pending #4246 |
|
/retest |
|
/lgtm /hold for SIG Release Lead to approve this |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gracenng, leonardpahlke, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of 1.28 release cycle commencing. Find 1.28 release team members here
As discussed with @furkatgofurov7, we will not add bug triage shadows to
milestone-maintainersuntil we find out where they'll need it.cc @kubernetes/sig-release-leads @leonardpahlke