Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update teams.yaml to address remaining changes for the v1.28 release cycle #4220

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Update teams.yaml to address remaining changes for the v1.28 release cycle #4220

merged 4 commits into from
Jul 13, 2023

Conversation

Atharva-Shinde
Copy link
Contributor

Changed teams.yaml to add new shadows and remove-update enhancements group of previous cycle

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2023
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label May 16, 2023
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2023
@Atharva-Shinde
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@Atharva-Shinde
Copy link
Contributor Author

/retest

1 similar comment
@Atharva-Shinde
Copy link
Contributor Author

/retest

@mrbobbytables
Copy link
Member

please ignore this - I'm testing something quick

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 18, 2023
@Atharva-Shinde
Copy link
Contributor Author

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2023
@gracenng
Copy link
Member

gracenng commented May 24, 2023 •
edited
Loading

thanks for opening this. can you pls wait for this to merge then PR the sig-arch change?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2023
@palnabarun
Copy link
Member

@Atharva-Shinde -- can you please resolve the merge conflicts on this?

MadhavJivrajani
MadhavJivrajani approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2023
@MadhavJivrajani
Copy link
Contributor

/hold
Please ping once conflicts are resolved.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2023
@Atharva-Shinde
Copy link
Contributor Author

Looks like most of the work that this PR intended was merged with the PR mentioned above: #4210. This PR now addresses remaining changes.

@Atharva-Shinde
Copy link
Contributor Author

^@palnabarun @MadhavJivrajani

@Atharva-Shinde Atharva-Shinde changed the title Add v1.28 Enhancements team to GitHub teams Update teams.yaml to address remaining changes for the v1.28 release cycle Jul 12, 2023
palnabarun
palnabarun approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Atharva-Shinde, MadhavJivrajani, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d7e697b into kubernetes:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@palnabarun palnabarun palnabarun approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@palnabarun palnabarun

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Atharva-Shinde @mrbobbytables @gracenng @palnabarun @MadhavJivrajani @k8s-ci-robot