Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2023-05-24 (include 1.28 Release Shadows) #4246

Merged
merged 7 commits into from
May 24, 2023
Merged

Add members 2023-05-24 (include 1.28 Release Shadows) #4246

merged 7 commits into from
May 24, 2023

Conversation

Priyankasaggu11929
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 commented May 24, 2023 •
edited
Loading

The PR:

fixes #4241
fixes #4238
fixes #4240

(1.28 Release Shadows)

fixes #4243
fixes #4235
fixes #4234
fixes #4233

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels May 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2023
This was referenced May 24, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@gracenng gracenng mentioned this pull request May 24, 2023
Merged
@palnabarun
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@Priyankasaggu11929
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 24, 2023
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request May 24, 2023
Closed
9 tasks
@Priyankasaggu11929
Copy link
Member Author

/unhold

@palnabarun, (apologies), I need another lgtm. Thank you 🙂

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@ameukam
Copy link
Member

ameukam commented May 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit a1b60b4 into kubernetes:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun Awaiting requested review from palnabarun

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@ameukam ameukam

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@Priyankasaggu11929 @palnabarun @k8s-ci-robot @ameukam