fix scale with windows nodes in cluster issue 4908 #5917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In terms of simply ignoring any windows nodes I think this would do the trick. a few things that I think you would need before this got merged:
|
zroubalik
reviewed
Jun 27, 2024
With this implementation, it would not work. Looking at the code again, we already say what platform we wish to scale from in the Keda settings. Now that we pull the platformName from the grid sessions I would think we just use that to make sure it matches the expected platformName in our Keda settings rather than just completely excluding windows. |
|
In my case, it’s enough to simply exclude Windows. This is because Windows nodes live in a VM. However, even before my PR, the user wouldn’t have been able to scale Windows nodes. I don’t quite understand which settings you are referring to, as I am not that deeply involved in your project. |
Doofus100500
force-pushed
the
fix-selenium-scaler
branch
from
d0a8994
to
24a61c6
Compare
@Wolfe1 Like that? |
|
@zroubalik @Wolfe1 Hi, is there a chance this PR will be accepted? |
Doofus100500
force-pushed
the
fix-selenium-scaler
branch
from
8ac3bbc
to
ccdeb4b
Compare
|
@zroubalik @Wolfe1 Hi, could you take another look? I added unit tests. Are you sure we need to add changes to e2e tests? There is nothing about the platform in the existing ones. |
Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: circa10a <caleblemoine@gmail.com> Signed-off-by: Caleb Lemoine <21261388+circa10a@users.noreply.github.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: novoselov <novoselov@skbkontur.ru>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
…5953) Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: novoselov <novoselov@skbkontur.ru>
* Add support to fetch username from env for MYSQL Scaler Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Add changelog Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Change if-else block to switch block Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Refactor scaler switch block Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Refactor method Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Refactor Mysql Scaler Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Address failure in static checks Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> * Address Review Comments Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> --------- Signed-off-by: Indresh2410 <indreshprakash24@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: semihbkgr <buyukgungorsemih@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
| datasource | package | from | to | | ----------- | -------------------- | ------ | ------ | | github-tags | actions/setup-python | v5.1.0 | v5.1.1 | Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
…/sdk/azidentity` (#5471) * Migrate EventHub SDK Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * remove old sdk Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * sort Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * migrate storage SDK Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update changelog and style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * migrate key vault Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix typos Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update azure monitor Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix typo Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix e2e tests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix error Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * use AZQUERY FOR MONITOR Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * use client optiosn Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * use sdk parsing function Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * migrate log analytics Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update tokens Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix typo Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Add missing changes Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * bump azure deps Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix packages Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix code Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix test Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix styles Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * remove todos Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
* feat: add TLS auth support for IBM MQ scaler Signed-off-by: rickbrouwer <75609067+rickbrouwer@users.noreply.github.com> * fix: fix ibmmq scaler test Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> * fix: correct httpClient Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: rickbrouwer <75609067+rickbrouwer@users.noreply.github.com> --------- Signed-off-by: rickbrouwer <75609067+rickbrouwer@users.noreply.github.com> Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
…ic value found (#5897) Signed-off-by: Benjamin Woodley <bwoodley012@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: novoselov <novoselov@skbkontur.ru>
* add core logic to support access token in postgres scaler Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * minor fix Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * run make build to fmt code Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * make regexp password pattern global Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * adapt to use placeholder for regexp Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * add missing authPodIdentity variable Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * lint code using gci write... command Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * lint import + add 2 unite tests Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * lint with make fmt Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * remove podIdentityAzure references (but keep AzureWorkload ones) Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * replace switch by if statements + fix error when comparing + close connection before recreating it Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * generate a new token if the current one has expired + add log info statement Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * minor change + add entry in CHANGELOG.md Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * Add first draft of an e2e test Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * Add comment and change package name Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * fix golanci lint Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * use identity 1 in e2e tests Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * fix e2e tests after testing it + change .env file Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * go fmt Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * remove entries in .env file Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * Add Postgres env variables Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * remove useless variables Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> * Update e2e test to reset all the task using a query Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * missing changes after rebase Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix typo in the query Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * remove the load Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Ferdinand de Baecque <45566171+Ferdinanddb@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@scrm.lidl> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
This scaledjob test template was missing its namespace, which doesn't generally matter for the test -- the test is just checking if the webhook works, it doesn't care where the scaledjob ends up. Where it does matter, is if you happen to run this test suite in a more restrictive environment where you can't write to the default namespace, because you fail with a namespace-related creation error instead of the expected "no triggers defined in the ScaledObject/ScaledJob" error. This just adds the namespace to the template so it's just like all the other ones in the test suite. Signed-off-by: John Kyros <jkyros@redhat.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: novoselov <novoselov@skbkontur.ru>
…5496) * Add new Datadog External scaler to talk to the DCA Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Add ability to retrieve a metric value from the DCA Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Use datadogmetric naming convention Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Merge both Datadog scalers into one Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Add authMode to the TriggerAuthentication Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Add unit tests for Datadog scaler with Cluster Agent proxy Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Fix activation Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Add E2E tests for the Datadog scaler using the Cluster Agent proxy Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Fixes after rebase Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Rearrange Datadog tests Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Fix linting errors Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Keep token only auth Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Remove references to ca metadata Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * remove trailing space Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Add changelog entry for cluster agent as proxy feature Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Fix activation parameter for Datadog API Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Adjust Datadog test values Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Fix typo in Datadog test Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Make cluster agent metric server parameter mandatory Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Use only service name and namespace to resolve the Cluster Agent service IP Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> * Fix linting issues Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> --------- Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
…queueLengthStrategy (#5875) Signed-off-by: Leonardo D'Ippolito <contact@leodip.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: June Han <sorrowitsch@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
* Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <josef@kedify.io> * fix tests Signed-off-by: Josef Karasek <josef@kedify.io> * fix lint Signed-off-by: Josef Karasek <josef@kedify.io> * fix log message Signed-off-by: Josef Karasek <josef@kedify.io> * update changelog Signed-off-by: Josef Karasek <josef@kedify.io> * update changelog Signed-off-by: Josef Karasek <josef@kedify.io> * update changelog Signed-off-by: Josef Karasek <josef@kedify.io> --------- Signed-off-by: Josef Karasek <josef@kedify.io> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Josef Karasek <josef@kedify.io> Signed-off-by: novoselov <novoselov@skbkontur.ru>
* chore: build with keda-tools:1.22.5 to resolve CVE-2024-24790, CVE-2024-24789, and CVE-2024-24791 bump github.com/Azure/azure-sdk-for-go/sdk/azidentity to resolve CVE-2024-35255 Signed-off-by: Paul Yu <paul.d.yu@gmail.com> * chore: use go install instead of go get and replacing deprecated tools Signed-off-by: Paul Yu <paul.d.yu@gmail.com> * chore: vendor dependency cleanup Signed-off-by: Paul Yu <paul.d.yu@gmail.com> * Update missing references to 1.21 Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Paul Yu <paul.d.yu@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: lanting.chiang <lanting.chiang@robinhood.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
* Add first scaler version Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * small refactor for response validation Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Add 'from' property, rename host/token Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Add parsing tests Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * update changelog Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: damas <19289022+cyrilico@users.noreply.github.com> * Update values type to float64 Signed-off-by: damas <19289022+cyrilico@users.noreply.github.com> * Remove unnecessary conversion Signed-off-by: damas <19289022+cyrilico@users.noreply.github.com> * e2e tests Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Update dynatrace_test.go Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Fix bad templating for e2e tests Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Revert unnecessary (?) template variable change Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * Update tests/scalers/dynatrace/dynatrace_test.go Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * Do not allow token to be passed in scaledobject trigger Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Remove bad secret, tweak dynakube test config Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Rename property in response parsing Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Update tests/scalers/dynatrace/dynatrace_test.go Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * use new operator secret, update template variable naming Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * forgotten correct variable definition Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * try default value in query for e2e tests Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * fix missing closing parenthesis, bad indenting Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> * Update e2e test to use custom metrics Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * Close the body to fix static checks Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * use declarative scaler config Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> --------- Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com> Signed-off-by: damas <19289022+cyrilico@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: novoselov <novoselov@skbkontur.ru>
* Remove deprecated cortexOrgId in prometheus scaler Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> * Move to breaking changes Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> --------- Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: novoselov <novoselov@skbkontur.ru>
…nalMetric` (#6010) Signed-off-by: Max Cao <macao@redhat.com> Signed-off-by: novoselov <novoselov@skbkontur.ru>
Signed-off-by: novoselov <novoselov@skbkontur.ru>
Doofus100500
force-pushed
the
fix-selenium-scaler
branch
from
b16a5c8
to
eea7dcd
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
tests/internals/scaling_strategies/eager_scaling_strategy_test.go
Outdated
Show resolved
Hide resolved
tests/internals/scaling_strategies/eager_scaling_strategy_test.go
Outdated
Show resolved
Hide resolved
zroubalik
reviewed
Aug 7, 2024
There was a problem hiding this comment.
@Doofus100500 could you please keep here only relevant commits?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Checklist
Fixes #
#4908