feat: GCP Pub/Sub scaler add configurable fallback value when no metric value found #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caislear
force-pushed
the
gcp-pubsub-add-is-null-default-value
branch
from
b7f6dcf
to
19237c2
Compare
Caislear
changed the title
1 task
Caislear
force-pushed
the
gcp-pubsub-add-is-null-default-value
branch
from
19237c2
to
78765cc
Compare
|
/run-e2e gcp |
Caislear
force-pushed
the
gcp-pubsub-add-is-null-default-value
branch
from
78765cc
to
6b43b92
Compare
@zroubalik anything else needed from my side to get this pr merged in ? |
Signed-off-by: Benjamin Woodley <bwoodley012@gmail.com>
Caislear
force-pushed
the
gcp-pubsub-add-is-null-default-value
branch
from
6b43b92
to
aecfdfb
Compare
JorTurFer
approved these changes
Jul 22, 2024
|
/run-e2e gcp |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional valueIfNull configuration value to the GCP Pub/Sub as also found in the older GCP Stackdriver scaler. This allows for a default fallback value when GCP returns no value for a given metric. This prevents excessive error logging especially when using multiple pubsub scalers with low subscription traffic.
Checklist
Relates to #
#5896
Documentation update