fix: reassign err to prevent invalid return in KedaProvider GetExternalMetric
#6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcao13
force-pushed
the
fix-nil-dereference
branch
from
731a7fd
to
c4c850c
Compare
Signed-off-by: Max Cao <macao@redhat.com>
maxcao13
force-pushed
the
fix-nil-dereference
branch
from
c4c850c
to
d7c7f72
Compare
JorTurFer
approved these changes
Jul 31, 2024
|
/skip-e2e |
|
nice catch! Thanks for the fix ❤️ |
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
…nalMetric` (kedacore#6010) Signed-off-by: Max Cao <macao@redhat.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here in the the KedaProvider https://github.com/openshift/kedacore-keda/blob/be1b1737c53f708a62a6a7386b27f5f208bf7094/pkg/provider/provider.go#L92. The GetExternalMetric function can return nil,nil in the wait for the connection to be ready since it does not reassign the err variable.
The nil,nil gets dereferenced here: https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/1e7ed5df24ef39898861260b002d9400f2d09300/pkg/registry/external_metrics/reststorage.go#L87 and hence panics in the code.
This fix reassigns the
errso that an invalidnil,nilreturn can not happen.Checklist
Fixes #6009