Add eagerScalingStrategy for ScaledJob #5872
Conversation
Signed-off-by: June Han <sorrowitsch@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com>
junekhan
force-pushed
the
feat/eager-mode
branch
4 times, most recently
from
dc4f7ba
to
29006d3
Compare
Signed-off-by: June Han <sorrowitsch@gmail.com>
junekhan
force-pushed
the
feat/eager-mode
branch
from
29006d3
to
e911f6d
Compare
There was a problem hiding this comment.
Could you please open pr in https://github.com/kedacore/keda-docs/ to cover this new feature?
Sure, thanks! Will do that. |
|
/run-e2e internal |
|
@zroubalik Hi there, I'm sorry that the e2e test didn't go well. I'm glad to analyze the logs, although it seems that I don't have access to it. |
|
@junekhan you should be able to access the logs by following these steps (let me know if you are not): |
|
@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues. |
At the bottom of the output, there's log from KEDA operator as well. That's the best we can do, you can always run the failed test locally: https://github.com/kedacore/keda/tree/main/tests#specific-test |
@zroubalik Thanks for your hint! That looks daunting 😨 but I will try. |
…uration Signed-off-by: June Han <sorrowitsch@gmail.com>
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| password = fmt.Sprintf("%s-password", testName) | ||
| vhost = "/" | ||
| connectionString = fmt.Sprintf("amqp://%s:%s@rabbitmq.%s.svc.cluster.local/", user, password, rmqNamespace) | ||
| httpConnectionString = fmt.Sprintf("http://%s:%s@rabbitmq.%s.svc.cluster.local/", user, password, rmqNamespace) |
There was a problem hiding this comment.
Semgrep found a possible database connection string built with string concatenation. Check for proper encoding/escaping of components to prevent parse errors and injection vulnerabilities.
Ignore this finding from db-connection-string.Signed-off-by: June Han <sorrowitsch@gmail.com>
|
Could you please rerun the checks? The result doesn't make sense. |
Signed-off-by: June Han <sorrowitsch@gmail.com>
|
@junekhan so sorry for the delay, I have been busy and missed the notification |
|
/run-e2e internal |
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: June Han <sorrowitsch@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Added
eagerScalingStrategyforScaledJobChecklist
Fixes #5114
Relates to #