This repository was archived by the owner on May 12, 2021. It is now read-only.
vendor: Rely on new agent package types #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Depends on kata-containers/agent#400 |
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this pull request
Oct 25, 2018
Some structures such as Interface and Route are not only used by the kata-agent since they are generic enough to be reused by kata-runtime or kata-netmon. By splitting those structures into their separate package, we prevent their consumers from importing the whole protocols/grpc package which pulls a lot of unneeded content. Depends-on: github.com/kata-containers/runtime#858 Fixes kata-containers#399 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Author
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage ? 66.09%
=========================================
Files ? 87
Lines ? 10705
Branches ? 0
=========================================
Hits ? 7076
Misses ? 2897
Partials ? 732 |
|
lgtm |
sboeuf
pushed a commit
to sboeuf/agent
that referenced
this pull request
Oct 26, 2018
The Interface structure needs a new field 'type' so that we can properly determine the type of interface being described. This will be helpful for network hotplug, as it will be used to create the appropriate connection between the VM and the interface. Depends-on: github.com/kata-containers/runtime#858 Fixes kata-containers#401 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
added 2 commits
October 26, 2018 09:35
Some agent types definition that were generic enough to be reused everywhere, have been split from the initial grpc package. This prevents from importing the entire protobuf package through the grpc one, and prevents binaries such as kata-netmon to stay in sync with the types definitions. Fixes kata-containers#856 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Now that the agent has split the generic types in their own package, kata-netmon can use them directly and get rid of the duplication of those. This is very helpful as it will prevent structures from being out of sync between kata-netmon and the kata-runtime, without bringing in the huge overhead that the initial grpc package was introducing. Fixes kata-containers#857 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
sboeuf
force-pushed
the
rely_agent_types
branch
from
f055d9c to
38d56c9
Compare
Author
|
/test |
Author
|
Just updated the vendoring now that agent#400 has been merged. Let's wait for the CI and merge that ;) |
Author
|
This PR is ready and got all approvals it needs. Github seems to be stuck not reporting the true status of |
jshachm
pushed a commit
to jshachm/agent
that referenced
this pull request
Nov 22, 2018
Some structures such as Interface and Route are not only used by the kata-agent since they are generic enough to be reused by kata-runtime or kata-netmon. By splitting those structures into their separate package, we prevent their consumers from importing the whole protocols/grpc package which pulls a lot of unneeded content. Depends-on: github.com/kata-containers/runtime#858 Fixes kata-containers#399 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
jshachm
pushed a commit
to jshachm/agent
that referenced
this pull request
Nov 22, 2018
The Interface structure needs a new field 'type' so that we can properly determine the type of interface being described. This will be helpful for network hotplug, as it will be used to create the appropriate connection between the VM and the interface. Depends-on: github.com/kata-containers/runtime#858 Fixes kata-containers#401 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the agent has split some generic structures definitions from the gRPC protocol itself, this pull request takes care of the revendoring of this change from the runtime.
Also, because it allows binary importing this path to avoid overhead due to the whole protocol definition, the binary
kata-netmoncan now rely on those types instead of duplicating them.Fixes #856
Fixes #857