This repository was archived by the owner on May 12, 2021. It is now read-only.
proto: Split reusable structures into their own package #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
/test |
|
A la #402, Travis doesn't like this change either :( |
Author
|
Depends on kata-containers/tests#852 |
sboeuf
force-pushed
the
split_pkg
branch
3 times, most recently
from
b3f6bdb to
b6380f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 47.96% 47.96%
=======================================
Files 17 17
Lines 2648 2648
=======================================
Hits 1270 1270
Misses 1216 1216
Partials 162 162 |
Author
|
/test |
Some structures such as Interface and Route are not only used by the kata-agent since they are generic enough to be reused by kata-runtime or kata-netmon. By splitting those structures into their separate package, we prevent their consumers from importing the whole protocols/grpc package which pulls a lot of unneeded content. Depends-on: github.com/kata-containers/runtime#858 Fixes kata-containers#399 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Author
|
/test |
Author
|
@amshinde @devimc @caoruidong @jodh-intel |
amshinde
approved these changes
Oct 26, 2018
|
lgtm
|
Member
|
This is really helpful. lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some structures such as Interface and Route are not only used by the
kata-agent since they are generic enough to be reused by kata-runtime
or kata-netmon.
By splitting those structures into their separate package, we prevent
their consumers from importing the whole protocols/grpc package which
pulls a lot of unneeded content.
Depends-on: github.com/kata-containers/runtime#858
Fixes #399
Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com