Repository navigation
docs(#3132): criteria M2 snapshot + operator dual-run checklist - #3137
Closed
natechadwick-intsof wants to merge 1 commit into
Closed
natechadwick-intsof wants to merge 1 commit into
natechadwick-intsof wants to merge 1 commit into
Conversation
Refresh definition-XML shim removal criteria Status snapshot (2026-08-12) for M1/M2/M3/G1-G6 with merged PR links (#3024/#3025/#3026, cluster #2897) and open evidence PRs (#3130/#3131). Expand dual-run operator checklist for H2 qa-up and product install: how to read metrics, when shim must stay, and what evidence closes M2. Explicitly keep #2852 blocked until M1-M3+G1-G6. No code deletion. Parent: #2630 · Fixes #3132 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by step-3.7-flash · Input: 69.1K · Output: 10.1K · Cached: 376.7K Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
Superseded by #3140 — same-file thrash absorption; do not merge this PR. |
1 similar comment
Collaborator
Author
|
Superseded by #3140 — same-file thrash absorption; do not merge this PR. |
natechadwick
pushed a commit
that referenced
this pull request
Aug 12, 2026
* feat(sitemanage): default modernPackageRoots for product/H2 installs (#3130) When widgetDao.modernPackageRoots is blank, discover package roots under ${rxdeploydir}/Packages/Modern (PSModernPackageRootDefaults), materializing from the perc-packages classpath when the install tree is empty. Stage Packages/Modern in the distribution and include it in upgrade overwrite. Keeps PSLegacyDefinitionXmlShim dual-run fallback (#2852). Tests cover modern-present and modern-absent selection. Criteria/dual-run docs updated. Parent: #2630 · Fixes #3130 > Co-Authored by Grok Build using grok-4.5 with agent main. * fix(dual-run): selection metrics evidence harness for M2 (#3131) Add cumulative modern/legacy (and gadget none) dual-run counters, snapshot maps, and formatSelectionMetricsSummary() on PSWidgetDao and GadgetRegistry. CI harness tests assert modern vs legacy selection metrics; criteria doc documents how to measure M2. No shim deletion. Parent: #2630 > Co-Authored by Grok Build using grok-4.5 with agent main. * docs(#3132): criteria M2 snapshot + operator dual-run checklist Refresh definition-XML shim removal criteria Status snapshot (2026-08-12) for M1/M2/M3/G1-G6 with merged PR links (#3024/#3025/#3026, cluster #2897) and open evidence PRs (#3130/#3131). Expand dual-run operator checklist for H2 qa-up and product install: how to read metrics, when shim must stay, and what evidence closes M2. Explicitly keep #2852 blocked until M1-M3+G1-G6. No code deletion. Parent: #2630 · Fixes #3132 > Co-Authored by Grok Build using grok-4.5 with agent main. * fix(dual-run): Zip Slip guards + diagnostic logs for modern package roots (#3130) Address PR #3134 review threads: log resolved modern root paths and full IOException stack; jar URI parse without URL round-trip; safeResolveUnder on classpath materialize (CodeQL Zip Slip); unit coverage for path escape. > Co-Authored by Grok CLI using agent overnight-pr-follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only criteria closeout for Phase 3 residual #3132 (parent #2630): refresh dual-run removal criteria Status snapshot and expand the operator dual-run checklist so #2852 stays blocked until real M1–M3 + G1–G6 evidence — not agent guesswork.
Changes
definition-xml-shim-removal-criteria.mdmain(INFO logs + last-kind APIs)dual-run-legacy-definition-xml-shim.mdqa-up+ product install stepsOut of scope
Operator: Grok: night-issue-prs (model grok-4.5)
Parent tracker: #2630 · Grandparent: #2626 · Related blocked residual: #2852 · Fixes #3132
Test plan
origin/main: Widget def XML under Packages = 1 (perc.Testonly); component-package.json count = 77Product documentation
docs/ai-generated/...only; no customer product-docs surface changeBuild evidence (C3)
mvnw clean installrequired for pure markdown underdocs/ai-generated/