Repository navigation
feat(sitemanage): wire PSWidgetDao modern-first dual-run selection (#3024) - #3045
Merged
Merged
Conversation
…3024) Wire PSWidgetDao to PSLegacyDefinitionXmlShim for modern-preferred definition source selection while keeping the legacy Widgets XML content path and the shim itself (#2852). Expose test-visible selection kinds and INFO metrics. Optional widgetDao.modernPackageRoots (File.pathSeparator list). Fix XML repository stream leak so Windows temp dirs can close after poll. Also updates dual-run / Phase 5 criteria M2 snapshot notes (partial M2). Fixes #3024 Parent: #2630 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 11, 2026
natechadwick
approved these changes
Aug 11, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires production
PSWidgetDaoto modern-first dual-run selection viaPSLegacyDefinitionXmlShim(parent Phase 3 #2630 residual #3024). Keeps the legacy Widgets XML content path and does not delete the shim (#2852).PSWidgetDao.selectDefinitionSource(id)+ poll-time classification viaPSLegacyDefinitionXmlShim.selectDefinitiongetLastSelectionKind()/getSelectionKindsById()modern=/legacyWidgetXml=/total=widgetDao.modernPackageRoots(File.pathSeparatorlist of package roots)PSXmlFileDataRepository.fileToObject(Files.readString) so Windows temp dirs unlock after pollOperator: Grok: night-issue-prs (model grok-4.5)
Parent tracker: #2630 · Grandparent: #2626 · Fixes #3024
Test plan
PSWidgetDaoTest: modern preferred; legacy fallback; neither → clearPSDefinitionSourceNotFoundException; poll records kindsmodules/perc-packagesmvnw clean install(BUILD SUCCESS)projects/sitemanagemvnw clean install(BUILD SUCCESS; Tests run: 1027, Failures: 0, Errors: 0, Skipped: 125)Product documentation
docs/ai-generated/...(no new operator-facing product surface)Build evidence (C3)
modules/perc-packages,projects/sitemanagecd modules/perc-packages && ../../mvnw.cmd clean install→ BUILD SUCCESScd projects/sitemanage && ../../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 1027, Failures: 0, Errors: 0, Skipped: 125final/signature break on shared reverse-dep types; sitemanage depends on perc-packages for selection API)Out of scope