Repository navigation
cluster(night): dual-run shim thrash absorb (#3134 #3136 #3137) - #3140
Merged
Merged
Conversation
…3130) When widgetDao.modernPackageRoots is blank, discover package roots under ${rxdeploydir}/Packages/Modern (PSModernPackageRootDefaults), materializing from the perc-packages classpath when the install tree is empty. Stage Packages/Modern in the distribution and include it in upgrade overwrite. Keeps PSLegacyDefinitionXmlShim dual-run fallback (#2852). Tests cover modern-present and modern-absent selection. Criteria/dual-run docs updated. Parent: #2630 · Fixes #3130 > Co-Authored by Grok Build using grok-4.5 with agent main.
Add cumulative modern/legacy (and gadget none) dual-run counters, snapshot maps, and formatSelectionMetricsSummary() on PSWidgetDao and GadgetRegistry. CI harness tests assert modern vs legacy selection metrics; criteria doc documents how to measure M2. No shim deletion. Parent: #2630 > Co-Authored by Grok Build using grok-4.5 with agent main.
Refresh definition-XML shim removal criteria Status snapshot (2026-08-12) for M1/M2/M3/G1-G6 with merged PR links (#3024/#3025/#3026, cluster #2897) and open evidence PRs (#3130/#3131). Expand dual-run operator checklist for H2 qa-up and product install: how to read metrics, when shim must stay, and what evidence closes M2. Explicitly keep #2852 blocked until M1-M3+G1-G6. No code deletion. Parent: #2630 · Fixes #3132 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 12, 2026
natechadwick
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overnight same-file thrash absorption for dual-run / definition-XML shim work. Three owned open PRs all edited the same criteria/operator docs and/or
PSWidgetDao.java. This cluster unions their content againstmainso humans review one PR instead of thrashing merges.Thrash files
docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.mddocs/ai-generated/tasks/template-assembler-normalization/dual-run-legacy-definition-xml-shim.mdprojects/sitemanage/src/main/java/com/percussion/pagemanagement/dao/impl/PSWidgetDao.java(shared by feat(sitemanage): default modernPackageRoots for product/H2 installs (#3130) #3134 + fix(dual-run): selection metrics evidence harness for M2 (#3131) #3136)Absorbed content (union)
modernPackageRoots(PSModernPackageRootDefaults, distribution staging, Zip Slip guards + diagnostic logs)PSWidgetDao+GadgetRegistry, CI harness tests)Conflict resolution used union semantics (keep #3130 defaults + #3131 harness APIs + #3132 checklist/status; no unique adds dropped).
Supersedes
fix/issue-3130-default-modern-package-rootsfix/issue-3131-dual-run-selection-metrics-harnessfix/issue-3132-criteria-m2-snapshot-checklistDo not merge #3134 / #3136 / #3137 — they are superseded by this cluster.
Test plan / gates evidence
modules/perc-packagesmvnw clean installafter #3134projects/sitemanagemvnw clean installafter #3134projects/sitemanagemvnw clean installafter #3136WebUImvnw clean installafter #3136Operator
Grok: night-issue-prs (model grok-4.5)
Closes nothing by itself; original issues #3130/#3131/#3132 already closed or tracked on parent #2630. Leaves #2852 blocked until M1–M3 + G1–G6.