Repository navigation
fix(perc-content-explorer): PSOptionManager rawtypes residual (#3012) - #3058
Merged
Merged
Conversation
Parameterize residual raw Collection/Iterator and Map/HashMap on PSOptionManager (toXmlCollection + save postData payload). Add PSOptionManagerTest for pure helpers. No product behavior change. Parent residual tracker: #2326 / #2045 / #2200 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added
operator:grok
This was referenced Aug 11, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by step-3.7-flash · Input: 49.8K · Output: 6.5K · Cached: 358.9K Review guidance: REVIEW.md from base branch |
natechadwick
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameterize residual rawtypes on Desktop Content Explorer PSOptionManager after #2993 / PR #3011.
toXmlCollectionusesCollection<? extends IPSClientObjects>+ for-each (null elements still rejected); save path usesMap<String, String>for postDataPSOptionManagerTest(9) covering pure helperstoXmlCollectionandcomparePSFolderAclEditorDialog([8.2] perc-content-explorer: PSFolderAclEditorDialog rawtypes residual (#2380/#2045) #2439 In Progress)PSItemAssemblyManager(module still has raw Iterator/Map on assembly APIs)No product behavior change (compiler tech-debt only).
Parent residual tracker: #2326
Parent module: #2045
Monorepo: #2200
Prior slice: #2993
Fixes #3012
Test plan
cd modules/DesktopContentExplorer && ../../mvnw.cmd clean installdocs/ai-generated/code-reviews/issue-3012-psoptionmanager-rawtypes-erlang.mdProduct documentation
Build evidence (C3)
modules/DesktopContentExplorercd modules/DesktopContentExplorer; ../../mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 148, Failures: 0, Errors: 0, Skipped: 0Operator: Grok: night-issue-prs (model grok-4.5)