Skip to content

fix(perc-content-explorer): PSSearchDialog rawtypes residual (#2993) - #3011

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-2993-pssearchdialog-rawtypes
Aug 11, 2026
Merged

natechadwick merged 1 commit into
mainfrom
fix/issue-2993-pssearchdialog-rawtypes

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Parameterize residual rawtypes/unchecked on Desktop Content Explorer PSSearchDialog after #2939 / PR #2992.

  • PSSearchDialog: ctor/m_searchFieldFilterMap use Map<?, ?>; searchable fields cache Map<String, PSContentEditorFieldCataloger>; typed Iterator<PSSearchField> / Iterator<PSDisplayFormat>
  • Extracted pure helpers: collectSearchFieldNames, buildDisplayFormatIdNameMap, findDisallowedSynonymExpansionChars
  • Unit tests: PSSearchDialogTest (9)
  • Did not touch PSFolderAclEditorDialog ([8.2] perc-content-explorer: PSFolderAclEditorDialog rawtypes residual (#2380/#2045) #2439 In Progress)
  • Left for next residual: PSOptionManager (module still has raw Collection/Iterator/Map)

No product behavior change (compiler tech-debt only).

Parent residual tracker: #2326
Parent module: #2045
Monorepo: #2200
Prior slice: #2939

Fixes #2993

Test plan

  • cd modules/DesktopContentExplorer && ../../mvnw.cmd clean install
  • BUILD SUCCESS — Tests run: 139, Failures: 0
  • Erlang self-review: docs/ai-generated/code-reviews/issue-2993-pssearchdialog-rawtypes-erlang.md

Product documentation

  • N/A — pure rawtypes/generics tech-debt; no operator/user/API surface change

Build evidence (C3)

  • modules_built: modules/DesktopContentExplorer
  • build_evidence: cd modules/DesktopContentExplorer; ../../mvnw.cmd clean install → BUILD SUCCESS; Tests run: 139, Failures: 0, Errors: 0, Skipped: 0
  • downstream_checked: none (C2 N/A for final/sealed; ctor Maps tightened to types already used at sole call sites in PSActionManager — module suite compiled + tested)

Operator: Grok: night-issue-prs (model grok-4.5)

Co-Authored by Grok Build using grok-4.5 with agent main.

Type filter/searchableFieldsCache Maps and field/display-format Iterators
with real generics. Extract pure helpers (field names, display format map,
synonym special-char scan) with unit tests. No product behavior change.

Parent residual tracker: #2326 / #2045 / #2200
Prior slice: #2939 / PR #2992

Fixes #2993

> Co-Authored by Grok Build using grok-4.5 with agent main.
@kilo-code-bot

kilo-code-bot Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • modules/DesktopContentExplorer/src/main/java/com/percussion/cx/PSSearchDialog.java
  • modules/DesktopContentExplorer/src/test/java/com/percussion/cx/PSSearchDialogTest.java
  • docs/ai-generated/code-reviews/issue-2993-pssearchdialog-rawtypes-erlang.md

Reviewed by step-3.7-flash · Input: 65.4K · Output: 8.8K · Cached: 584.3K

Review guidance: REVIEW.md from base branch main

@natechadwick
natechadwick merged commit f86348c into main Aug 11, 2026
6 checks passed
@natechadwick
natechadwick deleted the fix/issue-2993-pssearchdialog-rawtypes branch August 11, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.2 This issue found in 8.2 release model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow tech-debt tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[8.2] perc-content-explorer: PSSearchDialog rawtypes residual (#2326/#2045)

2 participants