[ESIMD] Fix sampler/stream parameter handling for ESIMD kernels #5165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
zahiraam
requested review from
elizabethandrews,
premanandrao and
smanna12
as code owners
smanna12
reviewed
Dec 16, 2021
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Fznamznon
reviewed
Dec 17, 2021
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
smanna12
reviewed
Jan 14, 2022
Fznamznon
reviewed
Jan 17, 2022
Fznamznon
reviewed
Jan 17, 2022
Fznamznon
reviewed
Jan 17, 2022
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Contributor
|
@kbobrovs please verify functionality for ESIMD kernels. We are adding a diagnostic for when ESIMD kernels capture streams/samplers. |
kbobrovs
previously approved these changes
Jan 18, 2022
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
smanna12
previously approved these changes
Jan 19, 2022
bader
changed the title
Fznamznon
reviewed
Jan 20, 2022
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
zahiraam
dismissed stale reviews from smanna12 and elizabethandrews
via
9603dff
smanna12
approved these changes
Jan 20, 2022
Fznamznon
approved these changes
Jan 20, 2022
elizabethandrews
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl_explicit_simd attribute is crashing when used on a special class.