Responded to reviews

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

Author: zahiraam

clang/lib/Sema/SemaSYCL.cpp

@@ -1648,6 +1648,10 @@ class SyclKernelFieldChecker : public SyclKernelFieldHandler {
     assert(Util::isSyclSpecialType(Ty) &&
            "Should only be called on sycl special class types.");
     const RecordDecl *RecD = Ty->getAsRecordDecl();
+    if (IsSIMD && !Util::isSyclType(Ty, "accessor", true /*Tmp*/))
+      return SemaRef.Diag(Loc.getBegin(),
+                          diag::err_sycl_esimd_not_supported_for_type)
+             << RecD;
     if (const ClassTemplateSpecializationDecl *CTSD =
             dyn_cast<ClassTemplateSpecializationDecl>(RecD)) {
       const TemplateArgumentList &TAL = CTSD->getTemplateArgs();
@@ -1658,10 +1662,6 @@ class SyclKernelFieldChecker : public SyclKernelFieldHandler {
       if (TAL.size() > 5)
         return checkPropertyListType(TAL.get(5), Loc.getBegin());
     }
-    if (IsSIMD && !Util::isSyclType(Ty, "accessor", true /*Tmp*/))
-      return SemaRef.Diag(Loc.getBegin(),
-                          diag::err_sycl_esimd_not_supported_for_type)
-             << RecD;
     return false;
   }
 

clang/test/SemaSYCL/esimd-special-class.cpp

@@ -13,12 +13,12 @@ void test() {
   queue q;
 
   q.submit([&](handler &h) {
-    cl::sycl::sampler smplr;
+    cl::sycl::sampler Smplr;
     cl::sycl::stream Stream(1024, 128, h);
     // expected-note@+1{{in instantiation of function template specialization}}
     h.single_task<class esimd_kernel>(
         // expected-error@+1{{type 'sampler' is not supported in 'esimd' context}}
-        [=]() [[intel::sycl_explicit_simd]] { smplr.use(); });
+        [=]() [[intel::sycl_explicit_simd]] { Smplr.use(); });
 
     // expected-note@+1{{in instantiation of function template specialization}}
     h.single_task<class StreamTester>(