Skip to content

Commit 9603dff

Browse files
committed
Responded to reviews
Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>
1 parent 45dcd20 commit 9603dff

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11628,7 +11628,7 @@ def ext_sycl_2020_attr_spelling : ExtWarn<
1162811628
"use of attribute %0 is a SYCL 2020 extension">,
1162911629
InGroup<Sycl2017Compat>;
1163011630
def err_sycl_esimd_not_supported_for_type : Error<
11631-
"type %0 is not supported in 'esimd' context">;
11631+
"type %0 is not supported in ESIMD context">;
1163211632
def err_sycl_taking_address_of_wrong_function : Error<
1163311633
"taking address of a function not marked with "
1163411634
"'intel::device_indirectly_callable' attribute is not allowed in SYCL device "

clang/test/SemaSYCL/esimd-special-class.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
// RUN: %clang_cc1 -fsycl-is-device -verify \
2-
// RUN: -internal-isystem %S/Inputs -triple spir64-unknown-unknown \
3-
// RUN: -fsyntax-only -disable-llvm-passes -emit-llvm %s -o - %s
1+
// RUN: %clang_cc1 -fsycl-is-device -verify -internal-isystem %S/Inputs -fsyntax-only %s
42

53
// The test is to ensure that the use of sycl_explicit_simd attribute doesn't
64
// crash when used with sampler or stream. Currently samplers/stream are not
@@ -17,12 +15,12 @@ void test() {
1715
cl::sycl::stream Stream(1024, 128, h);
1816
// expected-note@+1{{in instantiation of function template specialization}}
1917
h.single_task<class SamplerTester>(
20-
// expected-error@+1{{type 'sampler' is not supported in 'esimd' context}}
18+
// expected-error@+1{{type 'sampler' is not supported in ESIMD context}}
2119
[=]() [[intel::sycl_explicit_simd]] { Smplr.use(); });
2220

2321
// expected-note@+1{{in instantiation of function template specialization}}
2422
h.single_task<class StreamTester>(
25-
// expected-error@+1{{type 'stream' is not supported in 'esimd' context}}
23+
// expected-error@+1{{type 'stream' is not supported in ESIMD context}}
2624
[=]() [[intel::sycl_explicit_simd]] { Stream.use(); });
2725
});
2826
}

0 commit comments

Comments
 (0)