Restart service if it is already running and upgraded via RPM

[nerijus]

Restart service if it is already running and upgraded via RPM. Other services do that and Fedora guidelines suggests it - https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#Systemd :

On upgrade, a package may only restart a service if it is running; it may not start it if it is off. Also, the service may not enable itself if it is currently disabled.

Fixes #3516.

[telegraf-tiger]

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

[nerijus]

!signed-cla

[telegraf-tiger]

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_armv7.tar.gz
armhf.deb	i386.rpm	freebsd_i386.tar.gz
i386.deb	ppc64le.rpm	linux_amd64.tar.gz
mips.deb	s390x.rpm	linux_arm64.tar.gz
mipsel.deb	x86_64.rpm	linux_armel.tar.gz
ppc64el.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

[nerijus]

Hmm, just tried to upgrade from the artifacts built from this PR, and after upgrade the running service was not restarted. Let me investigate more and update PR.

[powersj]

Hi,

You added this change to the post-remove.sh script. I think you actually want it in post-install.sh, similar to what the deb files do.

Thanks!

[Hipska]

Ouch, this will kill my current workflow.

I cannot easily restart the service, I need to start a failover instance to cover the time of stopping and startup of telegraf process. (Lots of input plugin sections)

Is there an option in yum or rpm to not do this auto-restart?

[nerijus]

Ouch, this will kill my current workflow.

I cannot easily restart the service, I need to start a failover instance to cover the time of stopping and startup of telegraf process. (Lots of input plugin sections)

Is there an option in yum or rpm to not do this auto-restart?

Of course, from man rpm:

       --noscripts, --nopre, --nopost, --nopreun, --nopostun, --nopretrans, --noposttrans
              Don't execute the scriptlet of the same name.  The --noscripts option is equivalent to

       --nopre --nopost --nopreun --nopostun --nopretrans --noposttrans

       and turns off the execution of the corresponding %pre, %post, %preun, %postun %pretrans, and %posttrans scriptlet(s).

[Hipska]

Damn, seems not possible with yum or ansible to stop this behaviour..

[nerijus]

You can always install package manually with ansible; if ansible module does not have noscripts functionality, you can always use shell module and install using rpm -U --noscripts.

[Hipska]

Yeah, but that's not really nice to do..

[nerijus]

You added this change to the post-remove.sh script. I think you actually want it in post-install.sh, similar to what the deb files do.

I added it to the post-remove.sh script because this is what other CentOS packages do - I checked postfix, dovecot, mariadb-server. The reason it did not restart is because postuninstall scriptlet of the old package is run (according to https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#Scriptlet_Ordering).
So it will restart on the second upgrade, and it happened after I tried dnf downgrade telegraf(telegraf package from artifacts built from this PR was installed) - service was restarted.
So the PR is final and can be merged.