Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement deprecation infrastructure #10200

Merged
merged 45 commits into from
Dec 1, 2021
Merged

feat: Implement deprecation infrastructure #10200

merged 45 commits into from
Dec 1, 2021

Conversation

reimda
Copy link
Contributor

@reimda reimda commented Dec 1, 2021

Fix conflicts in #9857

Sven Rebhan added 30 commits December 1, 2021 11:51
@reimda
Make version available in config.
0d8717c
@reimda
Define interface for declaring a plugin as deprecated.
8c52cee
@reimda
Define telegraf version for the non-tagged case.
abae081
@reimda
Implement deprecation handling.
aa4790e
@reimda
Handle deprecation.
f776ddf
@reimda
Deprecate httpjson as a showcase.
7c6e654
@reimda
Deprecate 'address' option of http_response as showcase.
09cbfa3
@reimda
Color deprecation output to increase visibility.
8d23064
@reimda
Report only those deprecated fields that contain data.
ceb67fd
@reimda
Flag known deprecated packages.
19c9cd8
@reimda
Refactor deprecation handling a bit and implement deprecation listing.
c0678ac
@reimda
Allow listing of deprecated plugins and options via telegraf cmd.
03da755
@reimda
Restore the old config.NewConfig().
9c4c1cd
@reimda
Fix linter issues.
f6d5db3
@reimda
Make tidy.
0792b91
@reimda
Add comment to walkPluginStruct().
4e6e293
@reimda
Pimp walkPluginStruct() to also walk structs embedded in slices/array…
b83dc36 
…s and maps.
@reimda
Print deprecation statistics which is also included in a log-file if …
75ee66d 
…configured.
@reimda
Enable plugin filtering for deprecation list.
246a650
@reimda
Add new command-line flag to documentation.
1d09c2e
@reimda
Fix doc alignment.
86e559b
@reimda
Fix linter error.
43079ae
@reimda
Implement discussed deprecation strategy and allow to specify a custo…
529557d 
…m removal version.
@reimda
Move deprecation info to long-term persistant tables.
7157598
@reimda
Print deprecation notice for deprecated and already removed plugins.
3374eae
@reimda
Use keyed fields.
ef8bfcb
@reimda
Allow <br> HTML elements for Markdown as they are often the only why …
aa5039d 
…to enforce a linebreak.
@reimda
Add inputs.io to list of deprecated plugins.
64e876a
@reimda
Remove color from deprecation output.
d51cf51
@reimda
Fix Makefile.
56ce5b0
Sven Rebhan added 15 commits December 1, 2021 11:52
@reimda
Use go-semver for versioning.
805cd32
@reimda
Simplify version handling in telegraf.
041cc5d
@reimda
Make version internal.
1dcb0d7
@reimda
Fix linter error.
2a21150
@reimda
Improve error message.
b9bb624
@reimda
Formatting.
4b1e449
@reimda
Update deprecation information from Changelog.
57cb429
@reimda
Revert "Remove color from deprecation output."
5db8685 
This reverts commit 3b95f31.
@reimda
Handle processor and aggregator deprecations as well.
0a34118
@reimda
Rename 'Level' to 'LogLevel'.
253cc59
@reimda
Make all versions tri-dotted format.
1a3b87d
@reimda
Print origin for version panic to ease debugging.
18dd40c
@reimda
Switch to 'github.com/blang/semver' as we already have this as a (ind…
7bde164 
…irect) dependency.
@reimda
Drop potential pre-release tags for telegraf when comparing the versi…
28ae447 
…ons.
@reimda
Revert "Switch to 'github.com/blang/semver' as we already have this a…
eeb9d7a 
…s a (indirect) dependency."

This reverts commit 184d745.
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 1, 2021
@reimda reimda merged commit df6bf48 into master Dec 1, 2021
@reimda reimda deleted the HRI-EU-deprecation branch December 1, 2021 19:38
@reimda reimda mentioned this pull request Dec 1, 2021
Closed
3 tasks
srebhan pushed a commit to HRI-EU/telegraf that referenced this pull request Dec 2, 2021
fix: Revert unintented corruption of the Makefile from influxdata#10200.
bc65bb6
@srebhan srebhan mentioned this pull request Dec 2, 2021
Merged
3 tasks
powersj pushed a commit that referenced this pull request Dec 2, 2021
@srebhan
fix: Revert unintented corruption of the Makefile from #10200. (#10203)
52c422a
MyaLongmire pushed a commit that referenced this pull request Dec 8, 2021
@srebhan @MyaLongmire
fix: Revert unintented corruption of the Makefile from #10200. (#10203)
d901351 
(cherry picked from commit 52c422a)
@Hipska Hipska mentioned this pull request Feb 9, 2022
Merged
42 tasks
phemmer added a commit to phemmer/telegraf that referenced this pull request Feb 18, 2022
@phemmer
Merge remote-tracking branch 'origin/master' into postgres
ddb5575 
* origin/master: (133 commits)
  chore: restart service if it is already running and upgraded via RPM (influxdata#9970)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10237)
  fix: Handle duplicate registration of protocol-buffer files gracefully. (influxdata#10188)
  fix(http_listener_v2): fix panic on close (influxdata#10132)
  feat: add Vault input plugin (influxdata#10198)
  feat: support aws managed service for prometheus (influxdata#10202)
  fix: Make telegraf compile on Windows with golang 1.16.2 (influxdata#10246)
  Update changelog
  feat: Modbus add per-request tags (influxdata#10231)
  fix: Implement NaN and inf handling for elasticsearch output (influxdata#10196)
  feat: add nomad input plugin (influxdata#10106)
  fix: Print loaded plugins and deprecations for once and test (influxdata#10205)
  fix: eliminate MIB dependency for ifname processor (influxdata#10214)
  feat: Optimize locking for SNMP MIBs loading. (influxdata#10206)
  feat: Add SMART plugin concurrency configuration option, nvme-cli v1.14+ support and lint fixes. (influxdata#10150)
  feat: update configs (influxdata#10236)
  fix(inputs/kube_inventory): set TLS server name config properly (influxdata#9975)
  fix: Sudden close of Telegraf caused by OPC UA input plugin (influxdata#10230)
  fix: bump github.com/eclipse/paho.mqtt.golang from 1.3.0 to 1.3.5 (influxdata#9913)
  fix: json_v2 parser timestamp setting (influxdata#10221)
  fix: ensure graylog spec fields not prefixed with '_' (influxdata#10209)
  docs: remove duplicate links in CONTRIBUTING.md (influxdata#10218)
  fix: pool detection and metrics gathering for ZFS >= 2.1.x (influxdata#10099)
  fix: parallelism fix for ifname processor (influxdata#10007)
  chore: Forbids "log" package only for aggregators, inputs, outputs, parsers and processors (influxdata#10191)
  docs: address documentation gap when running telegraf in k8s (influxdata#10215)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10211)
  fix: mqtt topic extracting no longer requires all three fields (influxdata#10208)
  fix: windows service - graceful shutdown of telegraf (influxdata#9616)
  feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10201)
  feat: Modbus support multiple slaves (gateway feature) (influxdata#9279)
  fix: Revert unintented corruption of the Makefile from influxdata#10200. (influxdata#10203)
  chore: remove triggering update-config bot in CI (influxdata#10195)
  Update changelog
  feat: Implement deprecation infrastructure (influxdata#10200)
  fix: extra lock on init for safety (influxdata#10199)
  fix: resolve influxdata#10027 (influxdata#10112)
  fix: register bigquery to output plugins influxdata#10177 (influxdata#10178)
  fix: sysstat use unique temp file vs hard-coded (influxdata#10165)
  refactor: snmp to use gosmi (influxdata#9518)
  ...
Hipska
Hipska reviewed Apr 28, 2022
View reviewed changes
cmd/telegraf/telegraf.go
Comment on lines +423 to +424
//nolint:revive // We will notice if Println fails
fmt.Println("Deprecated Input Plugins: ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reimda @srebhan I know its a little late, but just came to this nolint tag. Is there a reason we can't use this?

Suggested change
//nolint:revive // We will notice if Println fails
fmt.Println("Deprecated Input Plugins: ")
_, _ = fmt.Println("Deprecated Input Plugins: ")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hipska Hipska Hipska left review comments

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reimda @Hipska