Fix transpiler conflict detection and AST consistency #2513
+5
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues identified by Qodo bot code review on PR #2482:
Changes
Issue #3: Conflict Detection Indexing Bug
Problem:
ifthenhandlers received unique keyson.always()blocks collapsed to single key"on.always"on.always()blocks incorrectly flagged as conflictshandlers.length > 1, but all blocks collapsed to 1 keyFix:
${stmt.handler}:${stmtIndex}js/transpiler/transpiler/analyzer.js:528-530Impact:
on.always()handlersIssue #5: Raw Values Not Wrapped in Literal Nodes
Problem:
>=and<=optimization passed raw numbers instead of AST nodescondition.rightshould always be an AST nodeFix:
constValue±1in{type: 'Literal', value: ...}objectsjs/transpiler/transpiler/condition_generator.js:300,307Impact:
Testing
✅ All 27 transpiler test suites pass with 0 failures
Related